* [PATCH] linux-user: Drop uint and ulong
@ 2023-05-11 8:50 Juan Quintela
2023-05-11 10:15 ` Philippe Mathieu-Daudé
2023-05-11 10:38 ` Laurent Vivier
0 siblings, 2 replies; 4+ messages in thread
From: Juan Quintela @ 2023-05-11 8:50 UTC (permalink / raw)
To: qemu-devel; +Cc: Laurent Vivier, Juan Quintela, Richard Henderson
These are types not used anymore anywhere else.
Signed-off-by: Juan Quintela <quintela@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
---
linux-user/mmap.c | 2 +-
linux-user/syscall.c | 8 ++++----
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/linux-user/mmap.c b/linux-user/mmap.c
index 0aa8ae7356..55dd143a10 100644
--- a/linux-user/mmap.c
+++ b/linux-user/mmap.c
@@ -859,7 +859,7 @@ abi_long target_mremap(abi_ulong old_addr, abi_ulong old_size,
static bool can_passthrough_madvise(abi_ulong start, abi_ulong end)
{
- ulong addr;
+ abi_ulong addr;
if ((start | end) & ~qemu_host_page_mask) {
return false;
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 69f740ff98..dd0349712b 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -309,16 +309,16 @@ _syscall0(int, sys_gettid)
#endif
#if defined(TARGET_NR_getdents) && defined(EMULATE_GETDENTS_WITH_GETDENTS)
-_syscall3(int, sys_getdents, uint, fd, struct linux_dirent *, dirp, uint, count);
+_syscall3(int, sys_getdents, unsigned int, fd, struct linux_dirent *, dirp, unsigned int, count);
#endif
#if (defined(TARGET_NR_getdents) && \
!defined(EMULATE_GETDENTS_WITH_GETDENTS)) || \
(defined(TARGET_NR_getdents64) && defined(__NR_getdents64))
-_syscall3(int, sys_getdents64, uint, fd, struct linux_dirent64 *, dirp, uint, count);
+_syscall3(int, sys_getdents64, unsigned int, fd, struct linux_dirent64 *, dirp, unsigned int, count);
#endif
#if defined(TARGET_NR__llseek) && defined(__NR_llseek)
-_syscall5(int, _llseek, uint, fd, ulong, hi, ulong, lo,
- loff_t *, res, uint, wh);
+_syscall5(int, _llseek, unsigned int, fd, unsigned long, hi, unsigned long, lo,
+ loff_t *, res, unsigned int, wh);
#endif
_syscall3(int, sys_rt_sigqueueinfo, pid_t, pid, int, sig, siginfo_t *, uinfo)
_syscall4(int, sys_rt_tgsigqueueinfo, pid_t, pid, pid_t, tid, int, sig,
--
2.40.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] linux-user: Drop uint and ulong
2023-05-11 8:50 [PATCH] linux-user: Drop uint and ulong Juan Quintela
@ 2023-05-11 10:15 ` Philippe Mathieu-Daudé
2023-05-11 10:38 ` Laurent Vivier
1 sibling, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2023-05-11 10:15 UTC (permalink / raw)
To: Juan Quintela, qemu-devel; +Cc: Laurent Vivier, Richard Henderson
On 11/5/23 10:50, Juan Quintela wrote:
> These are types not used anymore anywhere else.
>
> Signed-off-by: Juan Quintela <quintela@redhat.com>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> linux-user/mmap.c | 2 +-
> linux-user/syscall.c | 8 ++++----
> 2 files changed, 5 insertions(+), 5 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] linux-user: Drop uint and ulong
2023-05-11 8:50 [PATCH] linux-user: Drop uint and ulong Juan Quintela
2023-05-11 10:15 ` Philippe Mathieu-Daudé
@ 2023-05-11 10:38 ` Laurent Vivier
2023-05-11 11:10 ` Juan Quintela
1 sibling, 1 reply; 4+ messages in thread
From: Laurent Vivier @ 2023-05-11 10:38 UTC (permalink / raw)
To: Juan Quintela, qemu-devel; +Cc: Richard Henderson
Le 11/05/2023 à 10:50, Juan Quintela a écrit :
> These are types not used anymore anywhere else.
>
> Signed-off-by: Juan Quintela <quintela@redhat.com>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> linux-user/mmap.c | 2 +-
> linux-user/syscall.c | 8 ++++----
> 2 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/linux-user/mmap.c b/linux-user/mmap.c
> index 0aa8ae7356..55dd143a10 100644
> --- a/linux-user/mmap.c
> +++ b/linux-user/mmap.c
> @@ -859,7 +859,7 @@ abi_long target_mremap(abi_ulong old_addr, abi_ulong old_size,
>
> static bool can_passthrough_madvise(abi_ulong start, abi_ulong end)
> {
> - ulong addr;
> + abi_ulong addr;
>
> if ((start | end) & ~qemu_host_page_mask) {
> return false;
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index 69f740ff98..dd0349712b 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -309,16 +309,16 @@ _syscall0(int, sys_gettid)
> #endif
>
> #if defined(TARGET_NR_getdents) && defined(EMULATE_GETDENTS_WITH_GETDENTS)
> -_syscall3(int, sys_getdents, uint, fd, struct linux_dirent *, dirp, uint, count);
> +_syscall3(int, sys_getdents, unsigned int, fd, struct linux_dirent *, dirp, unsigned int, count);
> #endif
> #if (defined(TARGET_NR_getdents) && \
> !defined(EMULATE_GETDENTS_WITH_GETDENTS)) || \
> (defined(TARGET_NR_getdents64) && defined(__NR_getdents64))
> -_syscall3(int, sys_getdents64, uint, fd, struct linux_dirent64 *, dirp, uint, count);
> +_syscall3(int, sys_getdents64, unsigned int, fd, struct linux_dirent64 *, dirp, unsigned int, count);
> #endif
> #if defined(TARGET_NR__llseek) && defined(__NR_llseek)
> -_syscall5(int, _llseek, uint, fd, ulong, hi, ulong, lo,
> - loff_t *, res, uint, wh);
> +_syscall5(int, _llseek, unsigned int, fd, unsigned long, hi, unsigned long, lo,
> + loff_t *, res, unsigned int, wh);
> #endif
> _syscall3(int, sys_rt_sigqueueinfo, pid_t, pid, int, sig, siginfo_t *, uinfo)
> _syscall4(int, sys_rt_tgsigqueueinfo, pid_t, pid, pid_t, tid, int, sig,
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] linux-user: Drop uint and ulong
2023-05-11 10:38 ` Laurent Vivier
@ 2023-05-11 11:10 ` Juan Quintela
0 siblings, 0 replies; 4+ messages in thread
From: Juan Quintela @ 2023-05-11 11:10 UTC (permalink / raw)
To: Laurent Vivier; +Cc: qemu-devel, Richard Henderson
Laurent Vivier <laurent@vivier.eu> wrote:
> Le 11/05/2023 à 10:50, Juan Quintela a écrit :
>> These are types not used anymore anywhere else.
>> Signed-off-by: Juan Quintela <quintela@redhat.com>
>> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
>> ---
>> linux-user/mmap.c | 2 +-
>> linux-user/syscall.c | 8 ++++----
>> 2 files changed, 5 insertions(+), 5 deletions(-)
>> diff --git a/linux-user/mmap.c b/linux-user/mmap.c
>> index 0aa8ae7356..55dd143a10 100644
>> --- a/linux-user/mmap.c
>> +++ b/linux-user/mmap.c
>> @@ -859,7 +859,7 @@ abi_long target_mremap(abi_ulong old_addr, abi_ulong old_size,
>> static bool can_passthrough_madvise(abi_ulong start, abi_ulong
>> end)
>> {
>> - ulong addr;
>> + abi_ulong addr;
>> if ((start | end) & ~qemu_host_page_mask) {
>> return false;
>> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
>> index 69f740ff98..dd0349712b 100644
>> --- a/linux-user/syscall.c
>> +++ b/linux-user/syscall.c
>> @@ -309,16 +309,16 @@ _syscall0(int, sys_gettid)
>> #endif
>> #if defined(TARGET_NR_getdents) &&
>> defined(EMULATE_GETDENTS_WITH_GETDENTS)
>> -_syscall3(int, sys_getdents, uint, fd, struct linux_dirent *, dirp, uint, count);
>> +_syscall3(int, sys_getdents, unsigned int, fd, struct linux_dirent *, dirp, unsigned int, count);
>> #endif
>> #if (defined(TARGET_NR_getdents) && \
>> !defined(EMULATE_GETDENTS_WITH_GETDENTS)) || \
>> (defined(TARGET_NR_getdents64) && defined(__NR_getdents64))
>> -_syscall3(int, sys_getdents64, uint, fd, struct linux_dirent64 *, dirp, uint, count);
>> +_syscall3(int, sys_getdents64, unsigned int, fd, struct linux_dirent64 *, dirp, unsigned int, count);
>> #endif
>> #if defined(TARGET_NR__llseek) && defined(__NR_llseek)
>> -_syscall5(int, _llseek, uint, fd, ulong, hi, ulong, lo,
>> - loff_t *, res, uint, wh);
>> +_syscall5(int, _llseek, unsigned int, fd, unsigned long, hi, unsigned long, lo,
>> + loff_t *, res, unsigned int, wh);
>> #endif
>> _syscall3(int, sys_rt_sigqueueinfo, pid_t, pid, int, sig, siginfo_t *, uinfo)
>> _syscall4(int, sys_rt_tgsigqueueinfo, pid_t, pid, pid_t, tid, int, sig,
>
> Reviewed-by: Laurent Vivier <laurent@vivier.eu>
I assume this goes through your tree, right?
Later, Juan.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-05-11 11:11 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-11 8:50 [PATCH] linux-user: Drop uint and ulong Juan Quintela
2023-05-11 10:15 ` Philippe Mathieu-Daudé
2023-05-11 10:38 ` Laurent Vivier
2023-05-11 11:10 ` Juan Quintela
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).