qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: Anton Johansson <anjo@rev.ng>, qemu-devel@nongnu.org
Subject: Re: [RFC PATCH 03/34] target/riscv: Fix size of mcause
Date: Wed, 24 Sep 2025 14:37:43 -0700	[thread overview]
Message-ID: <d78f6956-0800-4a7f-9cc0-7c2d9935dc3e@linaro.org> (raw)
In-Reply-To: <20250924072124.6493-4-anjo@rev.ng>

On 9/24/25 00:20, Anton Johansson via wrote:
> and update formatting in logs.
> 
> Signed-off-by: Anton Johansson <anjo@rev.ng>
> ---
>   target/riscv/cpu.h     | 2 +-
>   target/riscv/machine.c | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)

There is no updating of logs.  Incorrectly split patch?
Cut and paste error on the commit message?

r~

> 
> diff --git a/target/riscv/cpu.h b/target/riscv/cpu.h
> index 8c8d34f3ac..32e30a36ac 100644
> --- a/target/riscv/cpu.h
> +++ b/target/riscv/cpu.h
> @@ -323,7 +323,7 @@ struct CPUArchState {
>   
>       uint64_t mtvec;
>       uint64_t mepc;
> -    target_ulong mcause;
> +    uint64_t mcause;
>       uint64_t mtval;  /* since: priv-1.10.0 */
>   
>       uint64_t mctrctl;
> diff --git a/target/riscv/machine.c b/target/riscv/machine.c
> index f42be027e3..438c44dbb0 100644
> --- a/target/riscv/machine.c
> +++ b/target/riscv/machine.c
> @@ -442,7 +442,7 @@ const VMStateDescription vmstate_riscv_cpu = {
>           VMSTATE_UINT64(env.scause, RISCVCPU),
>           VMSTATE_UINT64(env.mtvec, RISCVCPU),
>           VMSTATE_UINT64(env.mepc, RISCVCPU),
> -        VMSTATE_UINTTL(env.mcause, RISCVCPU),
> +        VMSTATE_UINT64(env.mcause, RISCVCPU),
>           VMSTATE_UINT64(env.mtval, RISCVCPU),
>           VMSTATE_UINTTL(env.miselect, RISCVCPU),
>           VMSTATE_UINTTL(env.siselect, RISCVCPU),



  reply	other threads:[~2025-09-24 21:38 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-24  7:20 [RFC PATCH 00/34] single-binary: Make riscv cpu.h target independent Anton Johansson via
2025-09-24  7:20 ` [RFC PATCH 01/34] target/riscv: Use 32 bits for misa extensions Anton Johansson via
2025-09-24 10:43   ` Philippe Mathieu-Daudé
2025-09-24 13:00     ` Anton Johansson via
2025-09-24  7:20 ` [RFC PATCH 02/34] target/riscv: Fix size of trivial CPUArchState fields Anton Johansson via
2025-09-24 21:36   ` Richard Henderson
2025-09-28 23:15     ` Alistair Francis
2025-09-29  9:39       ` anjo@rev.ng via
2025-09-24  7:20 ` [RFC PATCH 03/34] target/riscv: Fix size of mcause Anton Johansson via
2025-09-24 21:37   ` Richard Henderson [this message]
2025-09-29  9:39     ` Anton Johansson via
2025-09-24  7:20 ` [RFC PATCH 04/34] target/riscv: Fix size of mhartid Anton Johansson via
2025-09-24  7:20 ` [RFC PATCH 05/34] target/riscv: Bugfix riscv_pmu_ctr_get_fixed_counters_val() Anton Johansson via
2025-09-24  7:20 ` [RFC PATCH 06/34] target/riscv: Combine mhpmevent and mhpmeventh Anton Johansson via
2025-09-24  7:20 ` [RFC PATCH 07/34] target/riscv: Combine mcyclecfg and mcyclecfgh Anton Johansson via
2025-09-24  7:20 ` [RFC PATCH 08/34] target/riscv: Combine minstretcfg and minstretcfgh Anton Johansson via
2025-09-24  7:20 ` [RFC PATCH 09/34] target/riscv: Combine mhpmcounter and mhpmcounterh Anton Johansson via
2025-09-24  7:21 ` [RFC PATCH 10/34] target/riscv: Fix size of gpr and gprh Anton Johansson via
2025-09-24  7:21 ` [RFC PATCH 11/34] target/riscv: Fix size of vector CSRs Anton Johansson via
2025-09-24  7:21 ` [RFC PATCH 12/34] target/riscv: Fix size of pc, load_[val|res] Anton Johansson via
2025-09-24  7:21 ` [RFC PATCH 13/34] target/riscv: Fix size of frm and fflags Anton Johansson via
2025-09-24  7:21 ` [RFC PATCH 14/34] target/riscv: Fix size of badaddr and bins Anton Johansson via
2025-09-24  7:21 ` [RFC PATCH 15/34] target/riscv: Fix size of guest_phys_fault_addr Anton Johansson via
2025-09-24  7:21 ` [RFC PATCH 16/34] target/riscv: Fix size of priv_ver and vext_ver Anton Johansson via
2025-09-24  7:21 ` [RFC PATCH 17/34] target/riscv: Fix size of retxh Anton Johansson via
2025-09-24  7:21 ` [RFC PATCH 18/34] target/riscv: Fix size of ssp Anton Johansson via
2025-09-24  7:21 ` [RFC PATCH 19/34] target/riscv: Fix size of excp_uw2 Anton Johansson via
2025-09-24  7:21 ` [RFC PATCH 20/34] target/riscv: Fix size of sw_check_code Anton Johansson via
2025-09-24  7:21 ` [RFC PATCH 21/34] target/riscv: Fix size of priv Anton Johansson via
2025-09-24  7:21 ` [RFC PATCH 22/34] target/riscv: Fix size of gei fields Anton Johansson via
2025-09-24  7:21 ` [RFC PATCH 23/34] target/riscv: Fix size of [m|s|vs]iselect fields Anton Johansson via
2025-09-24  7:21 ` [RFC PATCH 24/34] target/riscv: Fix arguments to board IMSIC emulation callbacks Anton Johansson via
2025-09-24  7:21 ` [RFC PATCH 25/34] target/riscv: Fix size of irq_overflow_left Anton Johansson via
2025-09-24  7:21 ` [RFC PATCH 26/34] target/riscv: Indent PMUFixedCtrState correctly Anton Johansson via
2025-09-24  7:21 ` [RFC PATCH 27/34] target/riscv: Replace target_ulong in riscv_cpu_get_trap_name() Anton Johansson via
2025-09-24  7:21 ` [RFC PATCH 28/34] target/riscv: Replace target_ulong in riscv_ctr_add_entry() Anton Johansson via
2025-09-24  7:21 ` [RFC PATCH 29/34] target/riscv: Fix size of trigger data Anton Johansson via
2025-09-24  7:21 ` [RFC PATCH 30/34] target/riscv: Fix size of mseccfg Anton Johansson via
2025-09-24  7:21 ` [RFC PATCH 31/34] target/riscv: Move debug.h include away from cpu.h Anton Johansson via
2025-09-24  7:21 ` [RFC PATCH 32/34] target/riscv: Move CSR declarations to separate csr.h header Anton Johansson via
2025-09-24  7:21 ` [RFC PATCH 33/34] target/riscv: Introduce externally facing CSR access functions Anton Johansson via
2025-09-24  7:21 ` [RFC PATCH 34/34] target/riscv: Make pmp.h target_ulong agnostic Anton Johansson via
2025-09-29 22:44 ` [RFC PATCH 00/34] single-binary: Make riscv cpu.h target independent Pierrick Bouvier
2025-09-30  2:03   ` Philippe Mathieu-Daudé
2025-09-30 18:08     ` Pierrick Bouvier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d78f6956-0800-4a7f-9cc0-7c2d9935dc3e@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=anjo@rev.ng \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).