From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 166F4C47094 for ; Tue, 8 Jun 2021 02:36:59 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 84B4960FF2 for ; Tue, 8 Jun 2021 02:36:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 84B4960FF2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:52482 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lqRbt-00088U-M8 for qemu-devel@archiver.kernel.org; Mon, 07 Jun 2021 22:36:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33820) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lqRbE-0007Mk-Ad for qemu-devel@nongnu.org; Mon, 07 Jun 2021 22:36:16 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:60579) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lqRbC-0006uX-Qb for qemu-devel@nongnu.org; Mon, 07 Jun 2021 22:36:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623119774; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=f2Drzxu4Hsot2hGAnHP1CexjSZmwVI2U4KHJ7exdzFs=; b=XgvF99pVJZ3tVFONwiAoLtvmrIp6+JXWjMZ8TOuSSy5Krj1X6B2ac06fmqbi3iKoBYGeBO wzG51qNWrYEgm1Ytv7Uj4vCXdbBWIr5qXtUPG28IySJhGMPyRk/SN3TuUTAQn5evyjfrXR yrhmrQn8uyAZbUcsHZDfq3aSbNGsiCQ= Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-147-ZqbcTxEsOmGzIgHhmgROFA-1; Mon, 07 Jun 2021 22:36:12 -0400 X-MC-Unique: ZqbcTxEsOmGzIgHhmgROFA-1 Received: by mail-pj1-f71.google.com with SMTP id b23-20020a17090ae397b0290163949acb4dso15727947pjz.9 for ; Mon, 07 Jun 2021 19:36:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=f2Drzxu4Hsot2hGAnHP1CexjSZmwVI2U4KHJ7exdzFs=; b=lEGa2yPD7hr4lapum//S/DcZ3FmS/RGkW0hKYskkS2dH1fpg+43MUK91VYFUVf31CB FljtfetiTXCJNyyg/BiSnQwPEDvsmrCuyxE10tpZ4Hix8+aKbTCPm4p8L/lDh6tiAFMB kWY7Iq1DXtq0iJExy03JOe8QkNJ7R98djZauiFjmf/T9DTY8LhOk1DlidvbuE3so5rQ5 57tO+Q9shBkknwbOsIQwyH5NfBDgt5ZWX9jbh6dawKYKjvOJUoar1OCzB3XA+HPCQVBE haEmI+/W1q5wL+Zq1hq0b0OWZx6Vd6ZJKXIi2we+igJFO7pbM4cxwmqOzTp81HJlfugm VBYg== X-Gm-Message-State: AOAM531y6UFe05dOenohK5VQ+WOPmyRBxrqi8l0jPNSVCpBK+pklkOC9 KXHQYpA7ETkxVEzk/8BNZiFVHmkMb2IDx+GGHPN3h/CwJYb/LqxT8VWb/kIo3VTZQ3WWw0ro+w6 wr0No4K+ZoePaG/w= X-Received: by 2002:a65:64c4:: with SMTP id t4mr20655904pgv.222.1623119771506; Mon, 07 Jun 2021 19:36:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwxqpYCZCHbB0xTyq7MHnXRO/QfaF6IN3YvcKBJhxyU8enynR4QMLngL0dJlSr31O18QopIWg== X-Received: by 2002:a65:64c4:: with SMTP id t4mr20655883pgv.222.1623119771216; Mon, 07 Jun 2021 19:36:11 -0700 (PDT) Received: from wangxiaodeMacBook-Air.local ([209.132.188.80]) by smtp.gmail.com with ESMTPSA id s24sm9338239pfh.104.2021.06.07.19.36.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 07 Jun 2021 19:36:10 -0700 (PDT) Subject: Re: [PATCH 2/2] vhost-vdpa: remove the unused vhost_vdpa_get_acked_features() To: Gautam Dawar , "mst@redhat.com" , "qemu-devel@nongnu.org" References: <20210602033127.40149-1-jasowang@redhat.com> <20210602033127.40149-2-jasowang@redhat.com> From: Jason Wang Message-ID: Date: Tue, 8 Jun 2021 10:36:06 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jasowang@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=gbk; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Received-SPF: pass client-ip=216.205.24.124; envelope-from=jasowang@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -4 X-Spam_score: -0.5 X-Spam_bar: / X-Spam_report: (-0.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.2, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, MIME_CHARSET_FARAWAY=2.45, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "lulu@redhat.com" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" ÔÚ 2021/6/6 ÉÏÎç1:19, Gautam Dawar дµÀ: > No user for this helper, let's remove it. > > [GD>>] These patches seem unrelated to me. Do you think they should be part of one patch series? It doesn't harm. I've queued this patch. Thanks > > Signed-off-by: Jason Wang > --- > include/net/vhost-vdpa.h | 1 - > net/vhost-vdpa.c | 9 --------- > 2 files changed, 10 deletions(-) > > diff --git a/include/net/vhost-vdpa.h b/include/net/vhost-vdpa.h index 45e34b7cfc..b81f9a6f2a 100644 > --- a/include/net/vhost-vdpa.h > +++ b/include/net/vhost-vdpa.h > @@ -15,7 +15,6 @@ > #define TYPE_VHOST_VDPA "vhost-vdpa" > > struct vhost_net *vhost_vdpa_get_vhost_net(NetClientState *nc); -uint64_t vhost_vdpa_get_acked_features(NetClientState *nc); > > extern const int vdpa_feature_bits[]; > > diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c index fe659ec9e2..8dc86332a6 100644 > --- a/net/vhost-vdpa.c > +++ b/net/vhost-vdpa.c > @@ -66,15 +66,6 @@ VHostNetState *vhost_vdpa_get_vhost_net(NetClientState *nc) > return s->vhost_net; > } > > -uint64_t vhost_vdpa_get_acked_features(NetClientState *nc) -{ > - VhostVDPAState *s = DO_UPCAST(VhostVDPAState, nc, nc); > - assert(nc->info->type == NET_CLIENT_DRIVER_VHOST_VDPA); > - s->acked_features = vhost_net_get_acked_features(s->vhost_net); > - > - return s->acked_features; > -} > - > static int vhost_vdpa_net_check_device_id(struct vhost_net *net) { > uint32_t device_id; > -- > 2.25.1 >