From: Richard Henderson <richard.henderson@linaro.org>
To: Jinjie Ruan <ruanjinjie@huawei.com>,
peter.maydell@linaro.org, eduardo@habkost.net,
marcel.apfelbaum@gmail.com, philmd@linaro.org,
wangyanan55@huawei.com, qemu-devel@nongnu.org,
qemu-arm@nongnu.org
Subject: Re: [RFC PATCH v6 12/23] target/arm: Handle NMI in arm_cpu_do_interrupt_aarch64()
Date: Tue, 5 Mar 2024 11:43:55 -1000 [thread overview]
Message-ID: <d7f0144a-07e7-4fbd-8558-ccc443d1f9e9@linaro.org> (raw)
In-Reply-To: <20240305070331.2151131-13-ruanjinjie@huawei.com>
On 3/4/24 21:03, Jinjie Ruan via wrote:
> According to Arm GIC section 4.6.3 Interrupt superpriority, the interrupt
> with superpriority is always IRQ, never FIQ, so the NMI exception trap entry
> behave like IRQ. And VNMI(vIRQ with Superpriority) can be raised from the
> GIC or come from the hcrx_el2.HCRX_VINMI bit.
>
> Signed-off-by: Jinjie Ruan<ruanjinjie@huawei.com>
> ---
> v6:
> - Not combine VFNMI with CPU_INTERRUPT_VNMI.
> v4:
> - Also handle VNMI in arm_cpu_do_interrupt_aarch64().
> v3:
> - Remove the FIQ NMI handle.
> ---
> target/arm/helper.c | 2 ++
> 1 file changed, 2 insertions(+)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2024-03-05 21:44 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-05 7:03 [RFC PATCH v6 00/23] target/arm: Implement FEAT_NMI and FEAT_GICv3_NMI Jinjie Ruan via
2024-03-05 7:03 ` [RFC PATCH v6 01/23] target/arm: Handle HCR_EL2 accesses for bits introduced with FEAT_NMI Jinjie Ruan via
2024-03-05 7:03 ` [RFC PATCH v6 02/23] target/arm: Add PSTATE.ALLINT Jinjie Ruan via
2024-03-05 7:03 ` [RFC PATCH v6 03/23] target/arm: Add support for FEAT_NMI, Non-maskable Interrupt Jinjie Ruan via
2024-03-05 7:03 ` [RFC PATCH v6 04/23] target/arm: Implement ALLINT MSR (immediate) Jinjie Ruan via
2024-03-05 21:36 ` Richard Henderson
2024-03-05 7:03 ` [RFC PATCH v6 05/23] target/arm: Support MSR access to ALLINT Jinjie Ruan via
2024-03-05 7:03 ` [RFC PATCH v6 06/23] target/arm: Add support for Non-maskable Interrupt Jinjie Ruan via
2024-03-05 21:41 ` Richard Henderson
2024-03-05 7:03 ` [RFC PATCH v6 07/23] target/arm: Add support for NMI in arm_phys_excp_target_el() Jinjie Ruan via
2024-03-05 7:03 ` [RFC PATCH v6 08/23] target/arm: Handle IS/FS in ISR_EL1 for NMI Jinjie Ruan via
2024-03-05 21:42 ` Richard Henderson
2024-03-05 7:03 ` [RFC PATCH v6 09/23] target/arm: Handle PSTATE.ALLINT on taking an exception Jinjie Ruan via
2024-03-05 7:03 ` [RFC PATCH v6 10/23] hw/arm/virt: Wire NMI and VNMI irq lines from GIC to CPU Jinjie Ruan via
2024-03-05 7:03 ` [RFC PATCH v6 11/23] hw/intc/arm_gicv3: Add external IRQ lines for NMI Jinjie Ruan via
2024-03-05 7:03 ` [RFC PATCH v6 12/23] target/arm: Handle NMI in arm_cpu_do_interrupt_aarch64() Jinjie Ruan via
2024-03-05 21:43 ` Richard Henderson [this message]
2024-03-05 7:03 ` [RFC PATCH v6 13/23] hw/intc/arm_gicv3: Add irq superpriority information Jinjie Ruan via
2024-03-05 7:03 ` [RFC PATCH v6 14/23] hw/intc/arm_gicv3_redist: Implement GICR_INMIR0 Jinjie Ruan via
2024-03-05 7:03 ` [RFC PATCH v6 15/23] hw/intc/arm_gicv3: Implement GICD_INMIR Jinjie Ruan via
2024-03-05 7:03 ` [RFC PATCH v6 16/23] hw/intc: Enable FEAT_GICv3_NMI Feature Jinjie Ruan via
2024-03-05 7:03 ` [RFC PATCH v6 17/23] hw/intc/arm_gicv3: Add NMI handling CPU interface registers Jinjie Ruan via
2024-03-05 21:50 ` Richard Henderson
2024-03-05 21:51 ` Richard Henderson
2024-03-05 7:03 ` [RFC PATCH v6 18/23] hw/intc/arm_gicv3: Handle icv_nmiar1_read() for icc_nmiar1_read() Jinjie Ruan via
2024-03-05 21:52 ` Richard Henderson
2024-03-05 7:03 ` [RFC PATCH v6 19/23] hw/intc/arm_gicv3: Implement NMI interrupt prioirty Jinjie Ruan via
2024-03-05 22:36 ` Richard Henderson
2024-03-06 2:32 ` Jinjie Ruan via
2024-03-05 7:03 ` [RFC PATCH v6 20/23] hw/intc/arm_gicv3: Report the NMI interrupt in gicv3_cpuif_update() Jinjie Ruan via
2024-03-05 7:03 ` [RFC PATCH v6 21/23] hw/intc/arm_gicv3: Report the VNMI interrupt Jinjie Ruan via
2024-03-05 7:03 ` [RFC PATCH v6 22/23] target/arm: Add FEAT_NMI to max Jinjie Ruan via
2024-03-05 7:03 ` [RFC PATCH v6 23/23] hw/arm/virt: Add FEAT_GICv3_NMI feature support in virt GIC Jinjie Ruan via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d7f0144a-07e7-4fbd-8558-ccc443d1f9e9@linaro.org \
--to=richard.henderson@linaro.org \
--cc=eduardo@habkost.net \
--cc=marcel.apfelbaum@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=ruanjinjie@huawei.com \
--cc=wangyanan55@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).