* [Qemu-devel] [PATCH] vhost-scsi: prevent using uninitialized vqs
@ 2018-10-12 9:07 yuchenlin
2018-10-22 2:17 ` yuchenlin
0 siblings, 1 reply; 4+ messages in thread
From: yuchenlin @ 2018-10-12 9:07 UTC (permalink / raw)
To: qemu-devel; +Cc: mst, yuchenlin, Forrest Liu
From: yuchenlin <yuchenlin@synology.com>
There are 3 virtqueues (ctrl, event and cmd) for virtio scsi device,
but seabios will only set the physical address for the 3rd one (cmd).
Then in vhost_virtqueue_start(), virtio_queue_get_desc_addr()
will be 0 for ctrl and event vq.
In this case, ctrl and event vq are not initialized.
vhost_verify_ring_mappings may use uninitialized vhost_virtqueue
such that vhost_verify_ring_part_mapping returns ENOMEM.
When encountered this problem, we got the following logs:
qemu-system-x86_64: Unable to map available ring for ring 0
qemu-system-x86_64: Verify ring failure on region 0
Signed-off-by: Forrest Liu <forrestl@synology.com>
Signed-off-by: yuchenlin <yuchenlin@synology.com>
---
hw/scsi/vhost-scsi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/scsi/vhost-scsi.c b/hw/scsi/vhost-scsi.c
index becf550085..7f21b4f9d6 100644
--- a/hw/scsi/vhost-scsi.c
+++ b/hw/scsi/vhost-scsi.c
@@ -183,7 +183,7 @@ static void vhost_scsi_realize(DeviceState *dev, Error **errp)
}
vsc->dev.nvqs = VHOST_SCSI_VQ_NUM_FIXED + vs->conf.num_queues;
- vsc->dev.vqs = g_new(struct vhost_virtqueue, vsc->dev.nvqs);
+ vsc->dev.vqs = g_new0(struct vhost_virtqueue, vsc->dev.nvqs);
vsc->dev.vq_index = 0;
vsc->dev.backend_features = 0;
--
2.18.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] vhost-scsi: prevent using uninitialized vqs
2018-10-12 9:07 [Qemu-devel] [PATCH] vhost-scsi: prevent using uninitialized vqs yuchenlin
@ 2018-10-22 2:17 ` yuchenlin
2018-10-22 23:49 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 4+ messages in thread
From: yuchenlin @ 2018-10-22 2:17 UTC (permalink / raw)
To: yuchenlin; +Cc: qemu-devel, mst, Forrest Liu
Ping?
On 2018-10-12 17:07, yuchenlin@synology.com wrote:
> From: yuchenlin <yuchenlin@synology.com>
>
> There are 3 virtqueues (ctrl, event and cmd) for virtio scsi device,
> but seabios will only set the physical address for the 3rd one (cmd).
> Then in vhost_virtqueue_start(), virtio_queue_get_desc_addr()
> will be 0 for ctrl and event vq.
>
> In this case, ctrl and event vq are not initialized.
> vhost_verify_ring_mappings may use uninitialized vhost_virtqueue
> such that vhost_verify_ring_part_mapping returns ENOMEM.
>
> When encountered this problem, we got the following logs:
>
> qemu-system-x86_64: Unable to map available ring for ring 0
> qemu-system-x86_64: Verify ring failure on region 0
>
> Signed-off-by: Forrest Liu <forrestl@synology.com>
> Signed-off-by: yuchenlin <yuchenlin@synology.com>
> ---
> hw/scsi/vhost-scsi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/scsi/vhost-scsi.c b/hw/scsi/vhost-scsi.c
> index becf550085..7f21b4f9d6 100644
> --- a/hw/scsi/vhost-scsi.c
> +++ b/hw/scsi/vhost-scsi.c
> @@ -183,7 +183,7 @@ static void vhost_scsi_realize(DeviceState *dev,
> Error **errp)
> }
>
> vsc->dev.nvqs = VHOST_SCSI_VQ_NUM_FIXED + vs->conf.num_queues;
> - vsc->dev.vqs = g_new(struct vhost_virtqueue, vsc->dev.nvqs);
> + vsc->dev.vqs = g_new0(struct vhost_virtqueue, vsc->dev.nvqs);
> vsc->dev.vq_index = 0;
> vsc->dev.backend_features = 0;
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] vhost-scsi: prevent using uninitialized vqs
2018-10-22 2:17 ` yuchenlin
@ 2018-10-22 23:49 ` Philippe Mathieu-Daudé
2018-10-23 12:56 ` Michael S. Tsirkin
0 siblings, 1 reply; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2018-10-22 23:49 UTC (permalink / raw)
To: yuchenlin; +Cc: Forrest Liu, qemu-devel, mst, qemu-stable
On 22/10/18 4:17, yuchenlin via Qemu-devel wrote:
> Ping?
>
> On 2018-10-12 17:07, yuchenlin@synology.com wrote:
>> From: yuchenlin <yuchenlin@synology.com>
>>
>> There are 3 virtqueues (ctrl, event and cmd) for virtio scsi device,
>> but seabios will only set the physical address for the 3rd one (cmd).
>> Then in vhost_virtqueue_start(), virtio_queue_get_desc_addr()
>> will be 0 for ctrl and event vq.
>>
>> In this case, ctrl and event vq are not initialized.
>> vhost_verify_ring_mappings may use uninitialized vhost_virtqueue
>> such that vhost_verify_ring_part_mapping returns ENOMEM.
>>
>> When encountered this problem, we got the following logs:
>>
>> qemu-system-x86_64: Unable to map available ring for ring 0
>> qemu-system-x86_64: Verify ring failure on region 0
>>
>> Signed-off-by: Forrest Liu <forrestl@synology.com>
>> Signed-off-by: yuchenlin <yuchenlin@synology.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>> ---
>> hw/scsi/vhost-scsi.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/hw/scsi/vhost-scsi.c b/hw/scsi/vhost-scsi.c
>> index becf550085..7f21b4f9d6 100644
>> --- a/hw/scsi/vhost-scsi.c
>> +++ b/hw/scsi/vhost-scsi.c
>> @@ -183,7 +183,7 @@ static void vhost_scsi_realize(DeviceState *dev,
>> Error **errp)
>> }
>>
>> vsc->dev.nvqs = VHOST_SCSI_VQ_NUM_FIXED + vs->conf.num_queues;
>> - vsc->dev.vqs = g_new(struct vhost_virtqueue, vsc->dev.nvqs);
>> + vsc->dev.vqs = g_new0(struct vhost_virtqueue, vsc->dev.nvqs);
>> vsc->dev.vq_index = 0;
>> vsc->dev.backend_features = 0;
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] vhost-scsi: prevent using uninitialized vqs
2018-10-22 23:49 ` Philippe Mathieu-Daudé
@ 2018-10-23 12:56 ` Michael S. Tsirkin
0 siblings, 0 replies; 4+ messages in thread
From: Michael S. Tsirkin @ 2018-10-23 12:56 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: yuchenlin, Forrest Liu, qemu-devel, qemu-stable
On Tue, Oct 23, 2018 at 01:49:16AM +0200, Philippe Mathieu-Daudé wrote:
> On 22/10/18 4:17, yuchenlin via Qemu-devel wrote:
> > Ping?
> >
> > On 2018-10-12 17:07, yuchenlin@synology.com wrote:
> > > From: yuchenlin <yuchenlin@synology.com>
> > >
> > > There are 3 virtqueues (ctrl, event and cmd) for virtio scsi device,
> > > but seabios will only set the physical address for the 3rd one (cmd).
> > > Then in vhost_virtqueue_start(), virtio_queue_get_desc_addr()
> > > will be 0 for ctrl and event vq.
> > >
> > > In this case, ctrl and event vq are not initialized.
> > > vhost_verify_ring_mappings may use uninitialized vhost_virtqueue
> > > such that vhost_verify_ring_part_mapping returns ENOMEM.
> > >
> > > When encountered this problem, we got the following logs:
> > >
> > > qemu-system-x86_64: Unable to map available ring for ring 0
> > > qemu-system-x86_64: Verify ring failure on region 0
> > >
> > > Signed-off-by: Forrest Liu <forrestl@synology.com>
> > > Signed-off-by: yuchenlin <yuchenlin@synology.com>
>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Thanks I will queue this.
> > > ---
> > > hw/scsi/vhost-scsi.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/hw/scsi/vhost-scsi.c b/hw/scsi/vhost-scsi.c
> > > index becf550085..7f21b4f9d6 100644
> > > --- a/hw/scsi/vhost-scsi.c
> > > +++ b/hw/scsi/vhost-scsi.c
> > > @@ -183,7 +183,7 @@ static void vhost_scsi_realize(DeviceState *dev,
> > > Error **errp)
> > > }
> > >
> > > vsc->dev.nvqs = VHOST_SCSI_VQ_NUM_FIXED + vs->conf.num_queues;
> > > - vsc->dev.vqs = g_new(struct vhost_virtqueue, vsc->dev.nvqs);
> > > + vsc->dev.vqs = g_new0(struct vhost_virtqueue, vsc->dev.nvqs);
> > > vsc->dev.vq_index = 0;
> > > vsc->dev.backend_features = 0;
> >
> >
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-10-23 12:56 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-10-12 9:07 [Qemu-devel] [PATCH] vhost-scsi: prevent using uninitialized vqs yuchenlin
2018-10-22 2:17 ` yuchenlin
2018-10-22 23:49 ` Philippe Mathieu-Daudé
2018-10-23 12:56 ` Michael S. Tsirkin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).