From: Richard Henderson <richard.henderson@linaro.org>
To: fanwj@mail.ustc.edu.cn
Cc: qemu-devel@nongnu.org, laurent@vivier.eu
Subject: Re: [PATCH] linux-user/i386: Properly align signal frame
Date: Fri, 26 May 2023 07:27:28 -0700 [thread overview]
Message-ID: <d82e342e-a0bc-b005-53fe-3a22fb8f8121@linaro.org> (raw)
In-Reply-To: <3cba4226.1d2fb.18855fc889f.Coremail.fanwj@mail.ustc.edu.cn>
On 5/25/23 19:56, fanwj@mail.ustc.edu.cn wrote:
>
> "The beginning of the structure, with pretaddr, should be just below 16-byte alignment."
>
> It is incorrect! The beginning of the structure, with pretaddr not aligned as 16-byte!
> On x86-64, It aligned as (16n - sizeof(void*)) because of instruction "call" !
Exactly: 16n - sizeof(void*) is why I mean by "just below 16-byte alignment".
Which is exactly what I have done...
>>> + esp = esp - *frame_size + sizeof(abi_ulong);
>>> + esp = ROUND_DOWN(esp, 16) - sizeof(abi_ulong);
... here.
r~
next prev parent reply other threads:[~2023-05-26 14:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-24 5:46 [PATCH] linux-user/i386: Properly align signal frame Richard Henderson
2023-05-24 5:50 ` Richard Henderson
2023-05-26 2:56 ` fanwj--- via
2023-05-26 14:27 ` Richard Henderson [this message]
2023-06-20 13:26 ` Richard Henderson
2023-06-30 17:53 ` Richard Henderson
2023-07-02 18:41 ` Michael Tokarev
2023-08-05 21:56 ` Michael Tokarev
2023-08-06 2:29 ` Richard Henderson
2023-10-26 6:35 ` Michael Tokarev
2023-10-27 4:07 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d82e342e-a0bc-b005-53fe-3a22fb8f8121@linaro.org \
--to=richard.henderson@linaro.org \
--cc=fanwj@mail.ustc.edu.cn \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).