From: Paolo Bonzini <pbonzini@redhat.com>
To: Lara Lazier <laramglazier@gmail.com>, qemu-devel@nongnu.org
Subject: Re: [PATCH] target/i386: Added V_INTR_PRIO check to virtual interrupts
Date: Wed, 28 Jul 2021 11:26:57 +0200 [thread overview]
Message-ID: <d834787d-a9a4-b3a3-b80b-087ed216181f@redhat.com> (raw)
In-Reply-To: <20210721152651.14683-1-laramglazier@gmail.com>
On 21/07/21 17:26, Lara Lazier wrote:
> +static inline bool ctl_has_irq(uint32_t int_ctl)
> +{
> + uint32_t int_prio;
> + uint32_t tpr;
> +
> + int_prio = (int_ctl & V_INTR_PRIO_MASK) >> V_INTR_MASKING_SHIFT;
Oops, I missed that this should be V_INTR_PRIO_SHIFT. Can you send the
correction please?
Thanks,
Paolo
> + tpr = int_ctl & V_TPR_MASK;
> + return (int_ctl & V_IRQ_MASK) && (int_prio >= tpr);
> +}
> +
prev parent reply other threads:[~2021-07-28 9:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-21 15:26 [PATCH] target/i386: Added V_INTR_PRIO check to virtual interrupts Lara Lazier
2021-07-21 15:26 ` [PATCH v2] target/i386: Added consistency checks for CR4 Lara Lazier
2021-07-21 15:26 ` [PATCH v2] target/i386: Added consistency checks for EFER Lara Lazier
2021-07-21 16:53 ` Paolo Bonzini
2021-07-28 9:26 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d834787d-a9a4-b3a3-b80b-087ed216181f@redhat.com \
--to=pbonzini@redhat.com \
--cc=laramglazier@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).