From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Laszlo Ersek <lersek@redhat.com>,
qemu devel list <qemu-devel@nongnu.org>
Subject: Re: [PATCH v2 1/2] edk2 build scripts: honor external BaseTools flags with uefi-test-tools
Date: Fri, 20 Sep 2019 10:43:05 +0200 [thread overview]
Message-ID: <d83a0575-5292-1049-db17-1aa54c957b74@redhat.com> (raw)
In-Reply-To: <20190920083808.21399-2-lersek@redhat.com>
On 9/20/19 10:38 AM, Laszlo Ersek wrote:
> Unify the recipe for "build-edk2-tools" in
> "tests/uefi-test-tools/Makefile" with the recipe for "edk2-basetools" in
> "roms/Makefile".
>
> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
>
> Notes:
> v2:
> - new patch
>
> tests/uefi-test-tools/Makefile | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/tests/uefi-test-tools/Makefile b/tests/uefi-test-tools/Makefile
> index 1d78bc14d51a..7e0177d7337e 100644
> --- a/tests/uefi-test-tools/Makefile
> +++ b/tests/uefi-test-tools/Makefile
> @@ -99,7 +99,9 @@ Build/bios-tables-test.%.efi: build-edk2-tools
> +./build.sh $(edk2_dir) BiosTablesTest $* $@
>
> build-edk2-tools:
> - $(MAKE) -C $(edk2_dir)/BaseTools
> + $(MAKE) -C $(edk2_dir)/BaseTools \
> + EXTRA_OPTFLAGS='$(EDK2_BASETOOLS_OPTFLAGS)' \
> + EXTRA_LDFLAGS='$(EDK2_BASETOOLS_LDFLAGS)'
>
> clean:
> rm -rf Build Conf log
>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
next prev parent reply other threads:[~2019-09-20 8:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-20 8:38 [PATCH v2 0/2] edk2 build scripts: eliminate python 2 dependency Laszlo Ersek
2019-09-20 8:38 ` [PATCH v2 1/2] edk2 build scripts: honor external BaseTools flags with uefi-test-tools Laszlo Ersek
2019-09-20 8:43 ` Philippe Mathieu-Daudé [this message]
2019-09-20 8:38 ` [PATCH v2 2/2] edk2 build scripts: work around TianoCore#1607 without forcing Python 2 Laszlo Ersek
2019-09-20 8:42 ` Philippe Mathieu-Daudé
2019-09-20 16:06 ` [PATCH v2 0/2] edk2 build scripts: eliminate python 2 dependency John Snow
2019-09-24 15:28 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d83a0575-5292-1049-db17-1aa54c957b74@redhat.com \
--to=philmd@redhat.com \
--cc=lersek@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).