From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47079) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fSTzz-0004Fp-5u for qemu-devel@nongnu.org; Mon, 11 Jun 2018 17:05:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fSTzy-0007y9-71 for qemu-devel@nongnu.org; Mon, 11 Jun 2018 17:05:11 -0400 References: <20180611205203.2624-1-mreitz@redhat.com> <20180611205203.2624-5-mreitz@redhat.com> From: Max Reitz Message-ID: Date: Mon, 11 Jun 2018 23:05:01 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="u0KsNzA89L1cKQY6DBmoPfVTMBdbOlfcT" Subject: Re: [Qemu-devel] [PATCH v2 04/10] qapi: Formalize qcow2 encryption probing List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , qemu-block@nongnu.org Cc: qemu-devel@nongnu.org, Markus Armbruster , "Daniel P . Berrange" , Michael Roth , Kevin Wolf This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --u0KsNzA89L1cKQY6DBmoPfVTMBdbOlfcT From: Max Reitz To: Eric Blake , qemu-block@nongnu.org Cc: qemu-devel@nongnu.org, Markus Armbruster , "Daniel P . Berrange" , Michael Roth , Kevin Wolf Message-ID: Subject: Re: [PATCH v2 04/10] qapi: Formalize qcow2 encryption probing References: <20180611205203.2624-1-mreitz@redhat.com> <20180611205203.2624-5-mreitz@redhat.com> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2018-06-11 23:02, Eric Blake wrote: > On 06/11/2018 03:51 PM, Max Reitz wrote: >> Currently, you can give no encryption format for a qcow2 file while >> still passing a key-secret.=C2=A0 That does not conform to the schema,= so >> this patch changes the schema to allow it. >> >> Signed-off-by: Max Reitz >> --- >> =C2=A0 qapi/block-core.json | 44 +++++++++++++++++++++++++++++++++++++= +++---- >> =C2=A0 block/qcow2.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0= 3 +++ >> =C2=A0 2 files changed, 43 insertions(+), 4 deletions(-) >=20 >> +## >> +# @ImageInfoSpecificQCow2EncryptionNoInfo: >> +# >> +# Only used for the qcow2 encryption format "auto" in which the actua= l >> +# encryption format is determined from the image header.=C2=A0 Theref= ore, >> +# this encryption format will never be reported in >> +# ImageInfoSpecificQCow2Encryption. >> +# >> +# Since: 3.0 >> +## >> +{ 'struct': 'ImageInfoSpecificQCow2EncryptionNoInfo', >> +=C2=A0 'data': { } } >=20 > Do we actually need this type, given Anton's work on making omitted > branches automatically use an empty struct? >=20 > https://lists.gnu.org/archive/html/qemu-devel/2018-05/msg06836.html Looks like no, we don't. Great! :-) I think I'll still keep part of the comment and move it down into the description of ImageInfoSpecificQCow2Encryption so that anyone who's wondering knows that this value won't appear. Thanks for reviewing and pointing me at it, Max --u0KsNzA89L1cKQY6DBmoPfVTMBdbOlfcT Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEkb62CjDbPohX0Rgp9AfbAGHVz0AFAlse4/0ACgkQ9AfbAGHV z0BWxAf+M99EJyJcK9adUJxUsb1xOTs/+mPI70ASSnhZI+GNy5eY5uqWSQY6P5j3 7BmggaKxNA6pJfhenR4RT6d2/+l6be+QnDncxIh+JgtKo6+UaabDWPKjq5BlEizw HsM8lQddVny3fdxPGSIhfAEr4+CPJFmH9nuIjzSLLkEjcfhBnjymbI/Q1clVVQyG 4/6P05gxubrhgpNnYnPjyh/p/yABKmuTiOdL6ut1G99mAtrIFvVZ4QpPhX8hHQyW rt2z4ghgnT5hqR44EGo7SA9+pivRz2S+qO6/2/bRJF2TCz146/sCojVn5bFsMMLo QNckMsjZKq7zDJDstIK7tcbBIctY5w== =EqXO -----END PGP SIGNATURE----- --u0KsNzA89L1cKQY6DBmoPfVTMBdbOlfcT--