Re: [Qemu-devel] [PATCH 1/2] tests/qemu-iotests/group: Remove some more tests from the "auto" group

[Thomas Huth <thuth@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1247 bytes --]

On 15/07/2019 17.12, Eric Blake wrote:
> On 7/15/19 9:54 AM, Thomas Huth wrote:
>> Remove some more tests from the "auto" group that either have issues
>> in certain environments (like macOS or FreeBSD, or on certain file systems
>> like ZFS or tmpfs), do not work with the qcow2 format, or that are simply
>> taking too much time.
>>
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>> ---
>>  tests/qemu-iotests/group | 109 ++++++++++++++++++++-------------------
>>  1 file changed, 55 insertions(+), 54 deletions(-)
> 
>>  251 rw auto quick
>>  252 rw auto backing quick
>> -253 rw auto quick
>> -254 rw auto backing quick
>> -255 rw auto quick
>> -256 rw auto quick
>> +253 rw o_direct quick
> 
> Where is the new 'o_direct' group documented?  Is this a typo for
> something else?

I needed a new group for test 142 since it would be without any group at
all otherwise:

-142 auto
+142 o_direct

Tests without a group are currently only possible if the line ends with
a space - which is quite error prone. So I think it's better to use a
new group here. Since 253 is about testing with O_DIRECT, too, I've put
it into this group, too. Sorry, I should have mentioned it in the patch
description.

 Thomas


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]