Re: [PATCH trivial] tests/qemu-iotests/tests/mirror-sparse: actually require O_DIRECT

["Philippe Mathieu-Daudé" <philmd@linaro.org>]

On 6/8/25 09:56, Michael Tokarev wrote:
> Commit c0ddcb2cbc146e introduced the test which uses cache=direct
> mode, without checking if the scratch filesystem supports O_DIRECT.
> A subsequent commit, afeb002e0ad49d, tried to fix that issue, but
> instead of checking for o_direct, it checked for
> `_supported_cache_modes none directsync`, which is not what the
> original mirror-sparse test uses.  Fix both by actually checking
> for o_direct.
> 
> Fixes: c0ddcb2cbc146e "tests: Add iotest mirror-sparse for recent patches"
> Fixes: afeb002e0ad49d "tests/qemu-iotests/tests/mirror-sparse: skip if O_DIRECT is not supported"
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> ---
> This is what happens when rushing for last-minute
> pre-release fixes..  I'm sorry for this.

My bad actually :/

> 
>   tests/qemu-iotests/tests/mirror-sparse | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/qemu-iotests/tests/mirror-sparse b/tests/qemu-iotests/tests/mirror-sparse
> index 3b183eea88..ee7101bd50 100755
> --- a/tests/qemu-iotests/tests/mirror-sparse
> +++ b/tests/qemu-iotests/tests/mirror-sparse
> @@ -40,7 +40,7 @@ cd ..
>   _supported_fmt qcow2 raw  # Format of the source. dst is always raw file
>   _supported_proto file
>   _supported_os Linux
> -_supported_cache_modes none directsync
> +_require_o_direct
>   _require_disk_usage
>   
>   echo