From: David Hildenbrand <david@redhat.com>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Subject: Re: [PATCH 7/7] target/s390x: Hoist some computation in access_memmove
Date: Wed, 11 Jan 2023 11:22:55 +0100 [thread overview]
Message-ID: <d8513ea3-abec-08a9-3997-54fd83d472f2@redhat.com> (raw)
In-Reply-To: <20230109201856.3916639-8-richard.henderson@linaro.org>
On 09.01.23 21:18, Richard Henderson wrote:
> Ensure that the total length is in a local variable
> across the byte loop. Compute size1 difference once.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> target/s390x/tcg/mem_helper.c | 13 +++++++------
> 1 file changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/target/s390x/tcg/mem_helper.c b/target/s390x/tcg/mem_helper.c
> index 92eb6564c3..5f0dd67985 100644
> --- a/target/s390x/tcg/mem_helper.c
> +++ b/target/s390x/tcg/mem_helper.c
> @@ -299,16 +299,17 @@ static void access_set_byte(CPUS390XState *env, S390Access *access,
> static void access_memmove(CPUS390XState *env, S390Access *desta,
> S390Access *srca, uintptr_t ra)
> {
> + int len = desta->size1 + desta->size2;
> int diff;
I guess I'd have called "diff" something like "size1_diff" to make the
comparisons easier to digest.
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2023-01-11 10:23 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-09 20:18 [PATCH 0/7] target/s390x: mem_helper.c cleanups Richard Henderson
2023-01-09 20:18 ` [PATCH 1/7] target/s390x: Fix s390_probe_access for user-only Richard Henderson
2023-01-11 10:12 ` David Hildenbrand
2023-03-15 15:30 ` Thomas Huth
2023-03-16 14:29 ` Richard Henderson
2023-01-09 20:18 ` [PATCH 2/7] target/s390x: Pass S390Access pointer into access_prepare Richard Henderson
2023-01-11 10:13 ` David Hildenbrand
2023-01-09 20:18 ` [PATCH 3/7] target/s390x: Use void* for haddr in S390Access Richard Henderson
2023-01-11 10:15 ` David Hildenbrand
2023-01-09 20:18 ` [PATCH 4/7] target/s390x: Tidy access_prepare_nf Richard Henderson
2023-01-11 10:15 ` David Hildenbrand
2023-01-09 20:18 ` [PATCH 5/7] target/s390x: Remove TLB_NOTDIRTY workarounds Richard Henderson
2023-01-11 10:19 ` David Hildenbrand
2023-01-09 20:18 ` [PATCH 6/7] target/s390x: Inline do_access_{get,set}_byte Richard Henderson
2023-01-11 10:20 ` David Hildenbrand
2023-01-09 20:18 ` [PATCH 7/7] target/s390x: Hoist some computation in access_memmove Richard Henderson
2023-01-11 10:22 ` David Hildenbrand [this message]
2023-02-20 17:53 ` [PATCH 0/7] target/s390x: mem_helper.c cleanups Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d8513ea3-abec-08a9-3997-54fd83d472f2@redhat.com \
--to=david@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).