Re: [PATCH] nsis: Install *.elf images

["Philippe Mathieu-Daudé" <f4bug@amsat.org>]

On 3/26/21 7:21 AM, Bin Meng wrote:
> As of today, the QEMU Windows installer does not include the
> following two RISC-V BIOS images:
> 
> - opensbi-riscv64-generic-fw_dynamic.elf
> - opensbi-riscv32-generic-fw_dynamic.elf
> 
> Update the installer script to include them.
> 
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>

Following this series' idea:
https://www.mail-archive.com/qemu-devel@nongnu.org/msg794466.html
"blobs: Only install required (system emulation) files"

Maybe we can use meson + cpp with C #ifdef'ry (including
config-host.h + meson definitions) to generate qemu.nsi
with only required blobs?

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

> ---
> Based on:
> https://repo.or.cz/qemu/ar7.git/commit/657a6a90b69da971afdc71501c30275ba307ff6c
> 
> The above commit does not land on QEMU master. I am not sure what
> the process is, sending it here for comments.
> 
>  qemu.nsi | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/qemu.nsi b/qemu.nsi
> index 96c5534254..aeabe3bdbe 100644
> --- a/qemu.nsi
> +++ b/qemu.nsi
> @@ -142,6 +142,7 @@ Section "${PRODUCT}" QEMU_System_File_Section_Description
>  
>      File "${DATADIR}\*.bin"
>      File "${DATADIR}\*.dtb"
> +    File "${DATADIR}\*.elf"
>      File "${DATADIR}\*.fd"
>      File "${DATADIR}\*.img"
>      File "${DATADIR}\*.lid"
> @@ -258,6 +259,7 @@ Section "Uninstall" Uninstall_Section_Description
>      Delete "$INSTDIR\*.bin"
>      Delete "$INSTDIR\*.dll"
>      Delete "$INSTDIR\*.dtb"
> +    Delete "$INSTDIR\*.elf"
>      Delete "$INSTDIR\*.fd"
>      Delete "$INSTDIR\*.img"
>      Delete "$INSTDIR\*.lid"
>