From: Brad Smith <brad@comstyle.com>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Sean Bruno <sbruno@freebsd.org>,
patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH for-2.7] pc-bios/optionrom: Fix OpenBSD build with better detection of linker emulation
Date: Wed, 10 Aug 2016 20:28:05 -0400 [thread overview]
Message-ID: <d85decfc-f47e-e30d-e5ef-f5950009d309@comstyle.com> (raw)
In-Reply-To: <1470672688-6754-1-git-send-email-peter.maydell@linaro.org>
On 08/08/16 12:11, Peter Maydell wrote:
> The various host OSes are irritatingly variable about the name
> of the linker emulation we need to pass to ld's -m option to
> build the i386 option ROMs. Instead of doing this via a
> CONFIG ifdef, check in configure whether any of the emulation
> names we know about will work and pass the right answer through
> to the makefile. If we can't find one, we fall back to not trying
> to build the option ROMs, in the same way we would for a non-x86
> host platform.
>
> This is in particular necessary to unbreak the build on OpenBSD,
> since it wants a different answer to FreeBSD and we don't have
> an existing CONFIG_ variable that distinguishes the two.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> This works for Linux and for the Windows builds; I don't have any
> BSD systems to test it on. Brad and Sean, can I ask you to test this
> on OpenBSD and FreeBSD, please?
>
> (I think this is going to miss -rc2. Sorry about that; we'll
> get OpenBSD builds fixed for -rc3.)
Tested on OpenBSD/amd64 and it builds. Need to get my i386 VM going
and test on i386.
next prev parent reply other threads:[~2016-08-11 0:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-08 16:11 [Qemu-devel] [PATCH for-2.7] pc-bios/optionrom: Fix OpenBSD build with better detection of linker emulation Peter Maydell
2016-08-08 17:12 ` Peter Maydell
2016-08-09 13:12 ` Paolo Bonzini
2016-08-09 13:15 ` Peter Maydell
2016-08-08 18:05 ` Sean Bruno
2016-08-10 23:42 ` Brad Smith
2016-08-11 9:24 ` Peter Maydell
2016-08-11 0:28 ` Brad Smith [this message]
2016-08-15 17:26 ` Peter Maydell
2016-08-15 18:52 ` Brad Smith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d85decfc-f47e-e30d-e5ef-f5950009d309@comstyle.com \
--to=brad@comstyle.com \
--cc=patches@linaro.org \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=sbruno@freebsd.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).