From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ABA5FCA9EB5 for ; Mon, 4 Nov 2019 16:09:12 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7544120B7C for ; Mon, 4 Nov 2019 16:09:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="NhDLZ03/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7544120B7C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:34856 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iReul-0003lt-Fo for qemu-devel@archiver.kernel.org; Mon, 04 Nov 2019 11:09:11 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:49485) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iRetH-0002uz-IU for qemu-devel@nongnu.org; Mon, 04 Nov 2019 11:07:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iRetF-000801-83 for qemu-devel@nongnu.org; Mon, 04 Nov 2019 11:07:38 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:60606 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iRetF-0007yv-4X for qemu-devel@nongnu.org; Mon, 04 Nov 2019 11:07:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1572883656; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=NPJR68hHe4r6AMvwTHR3gJ/D+6q9Dpd3AOXqunrCS5s=; b=NhDLZ03/E9JSoDG2KND/QSJ2R9EQYEbI/sJ7fVqEEUIG78RNk7Zx4CMMaYO5WjZsPPJie2 Lbjb3sv8wlGmdPTV7w4fxZeBmHgzABgEAN2tcd7ogAomi71KmN4kEzP2quPn3bJxJ5JukV opzcE1+zfGGh5lyup9EIQfYdxXOECwc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-152-OAVMgQWoOmehehRgKlJ_cQ-1; Mon, 04 Nov 2019 11:07:32 -0500 X-MC-Unique: OAVMgQWoOmehehRgKlJ_cQ-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id AC02B1005500; Mon, 4 Nov 2019 16:07:31 +0000 (UTC) Received: from dresden.str.redhat.com (unknown [10.36.118.44]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5C76660136; Mon, 4 Nov 2019 16:07:25 +0000 (UTC) Subject: Re: [RFC 0/3] block/file-posix: Work around XFS bug To: Alberto Garcia , Vladimir Sementsov-Ogievskiy , "qemu-block@nongnu.org" References: <20191025095849.25283-1-mreitz@redhat.com> <02291bca-67d2-ed30-ac34-17641afbe397@virtuozzo.com> <0f75cbcf-e6c7-c74c-972b-22e7760a8b5c@redhat.com> <7ed9b8f0-2d8c-7bac-185e-9a1dd68fcce8@redhat.com> <5b67cf39-0ea1-d205-0e96-7b1148c7df19@redhat.com> From: Max Reitz Autocrypt: addr=mreitz@redhat.com; prefer-encrypt=mutual; keydata= mQENBFXOJlcBCADEyyhOTsoa/2ujoTRAJj4MKA21dkxxELVj3cuILpLTmtachWj7QW+TVG8U /PsMCFbpwsQR7oEy8eHHZwuGQsNpEtNC2G/L8Yka0BIBzv7dEgrPzIu+W3anZXQW4702+uES U29G8TP/NGfXRRHGlbBIH9KNUnOSUD2vRtpOLXkWsV5CN6vQFYgQfFvmp5ZpPeUe6xNplu8V mcTw8OSEDW/ZnxJc8TekCKZSpdzYoxfzjm7xGmZqB18VFwgJZlIibt1HE0EB4w5GsD7x5ekh awIe3RwoZgZDLQMdOitJ1tUc8aqaxvgA4tz6J6st8D8pS//m1gAoYJWGwwIVj1DjTYLtABEB AAG0HU1heCBSZWl0eiA8bXJlaXR6QHJlZGhhdC5jb20+iQFTBBMBCAA9AhsDBQkSzAMABQsJ CAcCBhUICQoLAgQWAgMBAh4BAheABQJVzie5FRhoa3A6Ly9rZXlzLmdudXBnLm5ldAAKCRD0 B9sAYdXPQDcIB/9uNkbYEex1rHKz3mr12uxYMwLOOFY9fstP5aoVJQ1nWQVB6m2cfKGdcRe1 2/nFaHSNAzT0NnKz2MjhZVmcrpyd2Gp2QyISCfb1FbT82GMtXFj1wiHmPb3CixYmWGQUUh+I AvUqsevLA+WihgBUyaJq/vuDVM1/K9Un+w+Tz5vpeMidlIsTYhcsMhn0L9wlCjoucljvbDy/ 8C9L2DUdgi3XTa0ORKeflUhdL4gucWoAMrKX2nmPjBMKLgU7WLBc8AtV+84b9OWFML6NEyo4 4cP7cM/07VlJK53pqNg5cHtnWwjHcbpGkQvx6RUx6F1My3y52vM24rNUA3+ligVEgPYBuQEN BFXOJlcBCADAmcVUNTWT6yLWQHvxZ0o47KCP8OcLqD+67T0RCe6d0LP8GsWtrJdeDIQk+T+F xO7DolQPS6iQ6Ak2/lJaPX8L0BkEAiMuLCKFU6Bn3lFOkrQeKp3u05wCSV1iKnhg0UPji9V2 W5eNfy8F4ZQHpeGUGy+liGXlxqkeRVhLyevUqfU0WgNqAJpfhHSGpBgihUupmyUg7lfUPeRM DzAN1pIqoFuxnN+BRHdAecpsLcbR8sQddXmDg9BpSKozO/JyBmaS1RlquI8HERQoe6EynJhd 64aICHDfj61rp+/0jTIcevxIIAzW70IadoS/y3DVIkuhncgDBvGbF3aBtjrJVP+5ABEBAAGJ ASUEGAEIAA8FAlXOJlcCGwwFCRLMAwAACgkQ9AfbAGHVz0CbFwf9F/PXxQR9i4N0iipISYjU sxVdjJOM2TMut+ZZcQ6NSMvhZ0ogQxJ+iEQ5OjnIputKvPVd5U7WRh+4lF1lB/NQGrGZQ1ic alkj6ocscQyFwfib+xIe9w8TG1CVGkII7+TbS5pXHRxZH1niaRpoi/hYtgzkuOPp35jJyqT/ /ELbqQTDAWcqtJhzxKLE/ugcOMK520dJDeb6x2xVES+S5LXby0D4juZlvUj+1fwZu+7Io5+B bkhSVPb/QdOVTpnz7zWNyNw+OONo1aBUKkhq2UIByYXgORPFnbfMY7QWHcjpBVw9MgC4tGeF R4bv+1nAMMxKmb5VvQCExr0eFhJUAHAhVg== Message-ID: Date: Mon, 4 Nov 2019 17:07:23 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="4z5yR5VhFYZOwEkgZ3B7nyMxtwzanH96Y" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 205.139.110.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Anton Nefedov , "qemu-devel@nongnu.org" , Stefan Hajnoczi Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --4z5yR5VhFYZOwEkgZ3B7nyMxtwzanH96Y Content-Type: multipart/mixed; boundary="at2vdsbXzrfERnlCrUQFCXl0SEhWOJOZ3" --at2vdsbXzrfERnlCrUQFCXl0SEhWOJOZ3 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 04.11.19 16:49, Alberto Garcia wrote: > On Mon 04 Nov 2019 04:14:56 PM CET, Max Reitz wrote: >=20 >>>> No, what I meant was that the original problem that led to >>>> c8bb23cbdbe would go away. >>> >>> Ah, right. Not quite, according to my numbers: >>> >>> |--------------+----------------+-----------------+-------------| >>> | Cluster size | subclusters=3Don | subclusters=3Doff | fallocate() | >>> |--------------+----------------+-----------------+-------------| >>> | 256 KB | 10182 IOPS | 966 IOPS | 14007 IOPS | >>> | 512 KB | 7919 IOPS | 563 IOPS | 13442 IOPS | >>> | 1024 KB | 5050 IOPS | 465 IOPS | 13887 IOPS | >>> | 2048 KB | 2465 IOPS | 271 IOPS | 13885 IOPS | >>> |--------------+----------------+-----------------+-------------| >>> >>> There's obviously no backing image, and only the last column uses >>> handle_alloc_space() / fallocate(). >> >> Thanks for providing some numbers! >> >> It was my impression, too, that subclusters wouldn=E2=80=99t solve it. = But it >> didn=E2=80=99t seem like that big of a difference to me. Did you run th= is >> with aio=3Dnative? (Because that=E2=80=99s where we have the XFS proble= m) >=20 > Here's with aio=3Dnative >=20 > |--------------+----------------+-----------------+-------------| > | Cluster size | subclusters=3Don | subclusters=3Doff | fallocate() | > |--------------+----------------+-----------------+-------------| > | 256 KB | 19897 IOPS | 891 IOPS | 32194 IOPS | > | 512 KB | 17881 IOPS | 436 IOPS | 33092 IOPS | > | 1024 KB | 17050 IOPS | 341 IOPS | 32768 IOPS | > | 2048 KB | 7854 IOPS | 207 IOPS | 30944 IOPS | > |--------------+----------------+-----------------+-------------| OK, thanks again. :-) So it seems right not to revert the commit and just work around the XFS bug in file-posix. Max --at2vdsbXzrfERnlCrUQFCXl0SEhWOJOZ3-- --4z5yR5VhFYZOwEkgZ3B7nyMxtwzanH96Y Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEkb62CjDbPohX0Rgp9AfbAGHVz0AFAl3ATLsACgkQ9AfbAGHV z0CjdAgAoq373MT6LTDhtJJsA8Q71GTjOzWvj5uAb1EvcpE1kOJiG5yhdLZuD0C5 Zm3ggzd4PPQ2Ev0Wj+q4A2RsF3opFB6/Txnxay3lAD+npFUHdgb6OkOU/0De2UCI nsYCOSSkeQgTVi6s8RQ2kUhz/cX2YSwUz2EeH1TiRm97UTLxFgCusYYnuzhIKEUy hF6Snsv3YuYHHFiMg2aA4285PuFFDJNfBzwKrGTdtroBFOVCZSZgfz3vedi/BB7U sSWp5rUvayC8wSbP1fDOdpLsdrytqRzwcjc3OAZSneIExrBTIwn6LAmL3k+eqwhR CWCnQSdmai8mdw1ohJpuqRQGTUnz0g== =V/Yo -----END PGP SIGNATURE----- --4z5yR5VhFYZOwEkgZ3B7nyMxtwzanH96Y--