[Qemu-devel] Subject: [PATCH]COLO: Fix spell error in Colo doc

[Qemu-devel] Subject: [PATCH]COLO: Fix spell error in Colo doc

[wangguang]

This is an error in COLO-FT.txt. 
secondeary-disk0 should be secondary-disk0. 

Signed-off-by: Guang Wang <wang.guang55@zte.com.cn>
--- 
 docs/COLO-FT.txt | 2 +- 
 1 file changed, 1 insertion(+), 1 deletion(-) 

diff --git a/docs/COLO-FT.txt b/docs/COLO-FT.txt 
index e289be2..bec7547 100644 
--- a/docs/COLO-FT.txt 
+++ b/docs/COLO-FT.txt 
@@ -139,7 +139,7 @@ Secondary: 
 { 'execute': 'nbd-server-start', 
   'arguments': {'addr': {'type': 'inet', 'data': {'host': 'xx.xx.xx.xx',
'port': '8889'} } } 
 } 
-{'execute': 'nbd-server-add', 'arguments': {'device': 'secondeary-disk0',
'writable': true } } 
+{'execute': 'nbd-server-add', 'arguments': {'device': 'secondary-disk0',
'writable': true } } 
  
 Note: 
   a. The qmp command nbd-server-start and nbd-server-add must be run 
-- 
2.9.3 





--
View this message in context: http://qemu.11.n7.nabble.com/Subject-PATCH-COLO-Fix-spell-error-in-Colo-doc-tp474448.html
Sent from the Developer mailing list archive at Nabble.com.

Re: [Qemu-devel] Subject: [PATCH]COLO: Fix spell error in Colo doc

[Eric Blake]

[-- Attachment #1: Type: text/plain, Size: 925 bytes --]

On 03/20/2017 09:49 PM, wangguang wrote:
> This is an error in COLO-FT.txt. 
> secondeary-disk0 should be secondary-disk0. 
> 
> Signed-off-by: Guang Wang <wang.guang55@zte.com.cn>

This is now version 6 of a patch, but failed to include that information
in the subject line.  'git send-email -v6' would do that automatically
for you.

> --- 

I already gave a positive review on v4, and repeated that on v5.  If you
are going to continue sending revisions to the list (rather than relying
on a maintainer to fix things up), then please remember to add
Reviewed-by tags from earlier revisions if you didn't change any code,
or else to include a changelog highlighting your code changes.

Other advice on sending a good patch can be seen at:
http://wiki.qemu-project.org/Contribute/SubmitAPatch

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]

Re: [Qemu-devel] Subject: [PATCH]COLO: Fix spell error in Colo doc

[Zhang Chen]

Hi~~ Wang.

This is a doc typo, but I found we forgot to update command in this doc,
Recently COLO use this command:
{'execute': 'nbd-server-add', 'arguments': {'device': 'colo-disk0', 
'writable': true } }

You can see it in http://wiki.qemu-project.org/Features/COLO.
So I think this patch is not necessary, I will update new command in 
docs/COLO-FT.txt later.

Please next time use scripts/get_maintainer.pl to cc related maintainers.

Thanks
Zhang Chen


On 03/21/2017 11:01 AM, Eric Blake wrote:
> On 03/20/2017 09:49 PM, wangguang wrote:
>> This is an error in COLO-FT.txt.
>> secondeary-disk0 should be secondary-disk0.
>>
>> Signed-off-by: Guang Wang <wang.guang55@zte.com.cn>
> This is now version 6 of a patch, but failed to include that information
> in the subject line.  'git send-email -v6' would do that automatically
> for you.
>
>> ---
> I already gave a positive review on v4, and repeated that on v5.  If you
> are going to continue sending revisions to the list (rather than relying
> on a maintainer to fix things up), then please remember to add
> Reviewed-by tags from earlier revisions if you didn't change any code,
> or else to include a changelog highlighting your code changes.
>
> Other advice on sending a good patch can be seen at:
> http://wiki.qemu-project.org/Contribute/SubmitAPatch
>

-- 
Thanks
Zhang Chen