From: Shivaprasad G Bhat <sbhat@linux.ibm.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: xiaoguangrong.eric@gmail.com, mst@redhat.com,
sbhat@linux.vnet.ibm.com, qemu-devel@nongnu.org,
qemu-ppc@nongnu.org, imammedo@redhat.com
Subject: Re: [PATCH v3 2/3] spapr: Add NVDIMM device support
Date: Mon, 16 Dec 2019 16:45:22 +0530 [thread overview]
Message-ID: <d872a780-cfae-bea5-21a9-83f1fa781c2f@linux.ibm.com> (raw)
In-Reply-To: <20191122043045.GD5582@umbus.fritz.box>
Hi David,
On 11/22/2019 10:00 AM, David Gibson wrote:
> On Mon, Oct 14, 2019 at 01:37:50PM -0500, Shivaprasad G Bhat wrote:
> ---
>> index 62f1a42592..815167e42f 100644
>> --- a/hw/ppc/spapr_drc.c
>> +++ b/hw/ppc/spapr_drc.c
>> @@ -708,6 +708,17 @@ static void spapr_drc_phb_class_init(ObjectClass *k, void *data)
>> drck->dt_populate = spapr_phb_dt_populate;
>> }
>>
>> +static void spapr_drc_pmem_class_init(ObjectClass *k, void *data)
>> +{
>> + SpaprDrcClass *drck = SPAPR_DR_CONNECTOR_CLASS(k);
>> +
>> + drck->typeshift = SPAPR_DR_CONNECTOR_TYPE_SHIFT_PMEM;
>> + drck->typename = "MEM";
> This is the same as the typename for LMB DRCs. Doesn't that mean that
> ibm,drc-types will end up with a duplicate in it?
Correct, this has to be "PMEM" instead of "MEM". Fixing it in next version.
Thanks,
Shivaprasad
>> + drck->drc_name_prefix = "PMEM ";
>>
next prev parent reply other threads:[~2019-12-16 11:47 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-14 18:37 [PATCH v3 0/3] ppc: spapr: virtual NVDIMM support Shivaprasad G Bhat
2019-10-14 18:37 ` [PATCH v3 1/3] mem: move nvdimm_device_list to utilities Shivaprasad G Bhat
2019-11-19 2:58 ` David Gibson
2019-11-19 7:13 ` Igor Mammedov
2019-11-20 8:01 ` Shivaprasad G Bhat
2019-11-20 9:35 ` Igor Mammedov
2019-10-14 18:37 ` [PATCH v3 2/3] spapr: Add NVDIMM device support Shivaprasad G Bhat
2019-11-22 4:30 ` David Gibson
2019-11-27 4:20 ` Bharata B Rao
2019-12-06 1:52 ` David Gibson
2019-12-11 4:14 ` Shivaprasad G Bhat
2019-12-11 8:05 ` Igor Mammedov
2019-12-12 8:52 ` Shivaprasad G Bhat
2020-01-03 0:45 ` David Gibson
2019-12-16 11:15 ` Shivaprasad G Bhat [this message]
2019-10-14 18:38 ` [PATCH v3 3/3] spapr: Add Hcalls to support PAPR NVDIMM device Shivaprasad G Bhat
2019-11-22 5:11 ` David Gibson
2019-12-17 6:10 ` Shivaprasad G Bhat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d872a780-cfae-bea5-21a9-83f1fa781c2f@linux.ibm.com \
--to=sbhat@linux.ibm.com \
--cc=david@gibson.dropbear.id.au \
--cc=imammedo@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=sbhat@linux.vnet.ibm.com \
--cc=xiaoguangrong.eric@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).