From: Richard Henderson <richard.henderson@linaro.org>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org, michael.roth@amd.com, jsnow@redhat.com
Subject: Re: [PATCH] qapi/parser: Fix type hints
Date: Tue, 16 May 2023 06:29:43 -0700 [thread overview]
Message-ID: <d8faf35f-ec66-9bce-e34e-4bde0b4fcd24@linaro.org> (raw)
In-Reply-To: <87sfbwx339.fsf@pond.sub.org>
On 5/15/23 22:22, Markus Armbruster wrote:
>> https://gitlab.com/qemu-project/qemu/-/jobs/4289613692#L574
>>
>> File "/builds/qemu-project/qemu/scripts/qapi/parser.py", line 566, in QAPIDoc
>> def _match_at_name_colon(string: str) -> Optional[re.Match[str]]:
>> TypeError: 'type' object is not subscriptable
>
> Life's too short for wrestling with such pigs. Unless John has better
> ideas, I'll *remove* these return type annotations. Maybe these pigs
> will behave after John's Python venv work lands.
>
That is exactly the idea that I had as well.
r~
next prev parent reply other threads:[~2023-05-16 13:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-11 11:17 [PATCH] qapi/parser: Fix type hints Markus Armbruster
2023-05-16 0:30 ` Richard Henderson
2023-05-16 5:22 ` Markus Armbruster
2023-05-16 13:29 ` Richard Henderson [this message]
2023-05-17 6:19 ` Markus Armbruster
2023-05-17 17:14 ` Paolo Bonzini
2023-05-22 7:51 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d8faf35f-ec66-9bce-e34e-4bde0b4fcd24@linaro.org \
--to=richard.henderson@linaro.org \
--cc=armbru@redhat.com \
--cc=jsnow@redhat.com \
--cc=michael.roth@amd.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).