qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Aditya Gupta <adityag@linux.ibm.com>
To: "Nicholas Piggin" <npiggin@gmail.com>, "Cédric Le Goater" <clg@kaod.org>
Cc: qemu-devel@nongnu.org, qemu-ppc@nongnu.org
Subject: Re: [PATCH v4] hw/ppc: Implement -dtb support for PowerNV
Date: Mon, 4 Nov 2024 11:19:24 +0530	[thread overview]
Message-ID: <d8ff3d90-a328-4be6-adf6-14ffed0faa38@linux.ibm.com> (raw)
In-Reply-To: <D5CIFVGK5UCZ.3S0N3TFQM5CCP@gmail.com>

On 03/11/24 17:04, Nicholas Piggin wrote:

> On Tue Aug 20, 2024 at 8:30 PM AEST, Aditya Gupta wrote:
>> Currently any device tree passed with -dtb option in QEMU, was ignored
>> by the PowerNV code.
>>
>> Read and pass the passed -dtb to the kernel, thus enabling easier
>> debugging with custom DTBs.
>>
>> The existing behaviour when -dtb is 'not' passed, is preserved as-is.
>>
>> But when a '-dtb' is passed, it completely overrides any dtb nodes or
>> changes QEMU might have done, such as '-append' arguments to the kernel
>> (which are mentioned in /chosen/bootargs in the dtb), hence add warning
>> when -dtb is being used
>>
>> Signed-off-by: Aditya Gupta <adityag@linux.ibm.com>
> Sorry for getting to it late,
>
> Reviewed-by: Nicholas Piggin <npiggin@gmail.com>

That's okay. Thanks for the tag Nick !


- Aditya Gupta




      reply	other threads:[~2024-11-04  5:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-20 10:30 [PATCH v4] hw/ppc: Implement -dtb support for PowerNV Aditya Gupta
2024-10-21  8:47 ` Aditya Gupta
2024-11-03 11:34 ` Nicholas Piggin
2024-11-04  5:49   ` Aditya Gupta [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d8ff3d90-a328-4be6-adf6-14ffed0faa38@linux.ibm.com \
    --to=adityag@linux.ibm.com \
    --cc=clg@kaod.org \
    --cc=npiggin@gmail.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).