From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,
BALATON Zoltan <balaton@eik.bme.hu>,
Bernhard Beschow <shentey@gmail.com>
Cc: qemu-devel@nongnu.org, "Jiaxun Yang" <jiaxun.yang@flygoat.com>,
"Niek Linnenbank" <nieklinnenbank@gmail.com>,
"Bin Meng" <bmeng.cn@gmail.com>,
"Paul Burton" <paulburton@kernel.org>,
"Stafford Horne" <shorne@gmail.com>,
qemu-ppc@nongnu.org, "Tyrone Ting" <kfting@nuvoton.com>,
"Joel Stanley" <joel@jms.id.au>,
"Eduardo Habkost" <eduardo@habkost.net>,
"Sergio Lopez" <slp@redhat.com>,
"Andrew Jeffery" <andrew@codeconstruct.com.au>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Hao Wu" <wuhaotsh@google.com>,
"Alistair Francis" <Alistair.Francis@wdc.com>,
"Jan Kiszka" <jan.kiszka@web.de>,
"Beniamino Galvani" <b.galvani@gmail.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Aurelien Jarno" <aurelien@aurel32.net>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Artyom Tarasenko" <atar4qemu@gmail.com>,
"Jia Liu" <proljc@gmail.com>, "Helge Deller" <deller@gmx.de>,
"Max Filippov" <jcmvbkbc@gmail.com>,
"Subbaraya Sundeep" <sundeep.lkml@gmail.com>,
"Weiwei Li" <liwei1518@gmail.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Nicholas Piggin" <npiggin@gmail.com>,
"Daniel Henrique Barboza" <dbarboza@ventanamicro.com>,
"Steven Lee" <steven_lee@aspeedtech.com>,
"Huacai Chen" <chenhuacai@kernel.org>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Strahinja Jankovic" <strahinja.p.jankovic@gmail.com>,
qemu-arm@nongnu.org, "Aleksandar Rikalo" <arikalo@gmail.com>,
"Troy Lee" <leetroy@gmail.com>,
"Jamin Lin" <jamin_lin@aspeedtech.com>,
"Liu Zhiwei" <zhiwei_liu@linux.alibaba.com>,
"Frédéric Barrat" <fbarrat@linux.ibm.com>,
"Cédric Le Goater" <clg@kaod.org>,
"Hervé Poussineau" <hpoussin@reactos.org>,
qemu-riscv@nongnu.org,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Song Gao" <gaosong@loongson.cn>
Subject: Re: [PATCH 2/5] hw/char/serial: Remove unused funtion
Date: Thu, 15 Aug 2024 11:26:38 +0200 [thread overview]
Message-ID: <d8ffe38c-756d-4187-875e-e6697631b7fa@linaro.org> (raw)
In-Reply-To: <11aeac5f-1985-494e-941a-5115d5e679bc@ilande.co.uk>
On 15/8/24 10:24, Mark Cave-Ayland wrote:
> On 14/08/2024 22:38, BALATON Zoltan wrote:
>
>> On Wed, 14 Aug 2024, Bernhard Beschow wrote:
>>> The serial port's frequency is set via the "baudbase" property nowadays.
>>
>> Please keep it as some devices might have registers that set this freq
>> and this function will be needed for emulating that even if it's not
>> emulated currently.
>
> Why not remove the function if it isn't being used? In general having
> unused code lying around is bad as it tends to bitrot.
>
> If someone did want to re-add this functionality then you would likely
> want to do it with clock API rather than using a separate function.
I also ended using it in a branch including this old series:
https://lore.kernel.org/qemu-devel/20200806130340.17316-1-f4bug@amsat.org/
Not my priority anymore, so I don't mind re-adding it.
next prev parent reply other threads:[~2024-08-15 9:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-14 18:15 [PATCH 0/5] Serial device cleanup Bernhard Beschow
2024-08-14 18:15 ` [PATCH 1/5] hw: Remove unused inclusion of hw/char/serial.h Bernhard Beschow
2024-08-21 14:39 ` Mark Cave-Ayland
2024-08-14 18:15 ` [PATCH 2/5] hw/char/serial: Remove unused funtion Bernhard Beschow
2024-08-14 21:38 ` BALATON Zoltan
2024-08-15 8:24 ` Mark Cave-Ayland
2024-08-15 9:26 ` Philippe Mathieu-Daudé [this message]
2024-08-15 18:00 ` Bernhard Beschow
2024-08-14 18:15 ` [PATCH 3/5] hw/ppc/Kconfig: Add missing SERIAL_ISA dependency to POWERNV machine Bernhard Beschow
2024-08-16 9:18 ` Philippe Mathieu-Daudé
2024-08-21 14:42 ` Mark Cave-Ayland
2024-08-14 18:15 ` [PATCH 4/5] hw/char/serial.h: Extract serial-isa.h Bernhard Beschow
2024-08-21 14:44 ` Mark Cave-Ayland
2024-08-14 18:15 ` [PATCH 5/5] hw/char: Extract serial-mm Bernhard Beschow
2024-08-15 0:35 ` Andrew Jeffery
2024-08-21 14:48 ` Mark Cave-Ayland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d8ffe38c-756d-4187-875e-e6697631b7fa@linaro.org \
--to=philmd@linaro.org \
--cc=Alistair.Francis@wdc.com \
--cc=andrew@codeconstruct.com.au \
--cc=arikalo@gmail.com \
--cc=atar4qemu@gmail.com \
--cc=aurelien@aurel32.net \
--cc=b.galvani@gmail.com \
--cc=balaton@eik.bme.hu \
--cc=bmeng.cn@gmail.com \
--cc=chenhuacai@kernel.org \
--cc=clg@kaod.org \
--cc=dbarboza@ventanamicro.com \
--cc=deller@gmx.de \
--cc=edgar.iglesias@gmail.com \
--cc=eduardo@habkost.net \
--cc=fbarrat@linux.ibm.com \
--cc=gaosong@loongson.cn \
--cc=hpoussin@reactos.org \
--cc=jamin_lin@aspeedtech.com \
--cc=jan.kiszka@web.de \
--cc=jcmvbkbc@gmail.com \
--cc=jiaxun.yang@flygoat.com \
--cc=joel@jms.id.au \
--cc=kfting@nuvoton.com \
--cc=leetroy@gmail.com \
--cc=liwei1518@gmail.com \
--cc=marcandre.lureau@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=mst@redhat.com \
--cc=nieklinnenbank@gmail.com \
--cc=npiggin@gmail.com \
--cc=palmer@dabbelt.com \
--cc=paulburton@kernel.org \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=proljc@gmail.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=shentey@gmail.com \
--cc=shorne@gmail.com \
--cc=slp@redhat.com \
--cc=steven_lee@aspeedtech.com \
--cc=strahinja.p.jankovic@gmail.com \
--cc=sundeep.lkml@gmail.com \
--cc=wuhaotsh@google.com \
--cc=zhiwei_liu@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).