Re: [PATCH v12 6/7] qemu-iotests: test new zone operations

[Dmitry Fomichev <Dmitry.Fomichev@wdc.com>]

On Tue, 2022-10-18 at 16:41 +0800, Sam Li wrote:
> Dmitry Fomichev <Dmitry.Fomichev@wdc.com> 于2022年10月17日周一 08:57写道：
> > 
> > On Sun, 2022-10-16 at 22:51 +0800, Sam Li wrote:
> > > We have added new block layer APIs of zoned block devices.
> > > Test it with:
> > > Create a null_blk device, run each zone operation on it and see
> > > whether reporting right zone information.
> > 
> > change this to "whether the logs show the correct zone information"?
> > 
> > > 
> > 
> > Could you please describe how to run this specific set of tests
> > in more detail?
> 
> I just run this script on the terminal directly and redirect the
> result to the output file.
> 
> Maybe?
> + Run each zone operation on a newly created null_blk device and see
> + whether the logs show the correct zone information.

Yes, this is fine. And specify the exact command line that you are using
to run the test.

> 
> > 
> > > 
> > > Signed-off-by: Sam Li <faithilikerun@gmail.com>
> > > Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
> > > ---
> > >  tests/qemu-iotests/tests/zoned.out | 53 ++++++++++++++++++
> > >  tests/qemu-iotests/tests/zoned.sh  | 86 ++++++++++++++++++++++++++++++
> > >  2 files changed, 139 insertions(+)
> > >  create mode 100644 tests/qemu-iotests/tests/zoned.out
> > >  create mode 100755 tests/qemu-iotests/tests/zoned.sh
> > > 
> > > diff --git a/tests/qemu-iotests/tests/zoned.out b/tests/qemu-
> > > iotests/tests/zoned.out
> > > new file mode 100644
> > > index 0000000000..0c8f96deb9
> > > --- /dev/null
> > > +++ b/tests/qemu-iotests/tests/zoned.out
> > > @@ -0,0 +1,53 @@
> > > +QA output created by zoned.sh
> > > +Testing a null_blk device:
> > > +Simple cases: if the operations work
> > > +(1) report the first zone:
> > > +start: 0x0, len 0x80000, cap 0x80000, wptr 0x0, zcond:1, [type: 2]
> > > +
> > > +report the first 10 zones
> > > +start: 0x0, len 0x80000, cap 0x80000, wptr 0x0, zcond:1, [type: 2]
> > > +start: 0x80000, len 0x80000, cap 0x80000, wptr 0x80000, zcond:1, [type: 2]
> > > +start: 0x100000, len 0x80000, cap 0x80000, wptr 0x100000, zcond:1, [type:
> > > 2]
> > > +start: 0x180000, len 0x80000, cap 0x80000, wptr 0x180000, zcond:1, [type:
> > > 2]
> > > +start: 0x200000, len 0x80000, cap 0x80000, wptr 0x200000, zcond:1, [type:
> > > 2]
> > > +start: 0x280000, len 0x80000, cap 0x80000, wptr 0x280000, zcond:1, [type:
> > > 2]
> > > +start: 0x300000, len 0x80000, cap 0x80000, wptr 0x300000, zcond:1, [type:
> > > 2]
> > > +start: 0x380000, len 0x80000, cap 0x80000, wptr 0x380000, zcond:1, [type:
> > > 2]
> > > +start: 0x400000, len 0x80000, cap 0x80000, wptr 0x400000, zcond:1, [type:
> > > 2]
> > > +start: 0x480000, len 0x80000, cap 0x80000, wptr 0x480000, zcond:1, [type:
> > > 2]
> > > +
> > > +report the last zone:
> > > +start: 0x1f380000, len 0x80000, cap 0x80000, wptr 0x1f380000, zcond:1,
> > > [type:
> > > 2]
> > > +
> > > +
> > > +(2) opening the first zone
> > > +report after:
> > > +start: 0x0, len 0x80000, cap 0x80000, wptr 0x0, zcond:3, [type: 2]
> > > +
> > > +opening the second zone
> > > +report after:
> > > +start: 0x80000, len 0x80000, cap 0x80000, wptr 0x80000, zcond:3, [type: 2]
> > > +
> > > +opening the last zone
> > > +report after:
> > > +start: 0x1f380000, len 0x80000, cap 0x80000, wptr 0x1f380000, zcond:3,
> > > [type:
> > > 2]
> > > +
> > > +
> > > +(3) closing the first zone
> > > +report after:
> > > +start: 0x0, len 0x80000, cap 0x80000, wptr 0x0, zcond:1, [type: 2]
> > > +
> > > +closing the last zone
> > > +report after:
> > > +start: 0x1f380000, len 0x80000, cap 0x80000, wptr 0x1f380000, zcond:1,
> > > [type:
> > > 2]
> > > +
> > > +
> > > +(4) finishing the second zone
> > > +After finishing a zone:
> > > +start: 0x80000, len 0x80000, cap 0x80000, wptr 0x100000, zcond:14, [type:
> > > 2]
> > > +
> > > +
> > > +(5) resetting the second zone
> > > +After resetting a zone:
> > > +start: 0x80000, len 0x80000, cap 0x80000, wptr 0x80000, zcond:1, [type: 2]
> > > +*** done
> > > diff --git a/tests/qemu-iotests/tests/zoned.sh b/tests/qemu-
> > > iotests/tests/zoned.sh
> > > new file mode 100755
> > > index 0000000000..fced0194c5
> > > --- /dev/null
> > > +++ b/tests/qemu-iotests/tests/zoned.sh
> > > @@ -0,0 +1,86 @@
> > > +#!/usr/bin/env bash
> > > +#
> > > +# Test zone management operations.
> > > +#
> > > +
> > > +seq="$(basename $0)"
> > > +echo "QA output created by $seq"
> > > +status=1 # failure is the default!
> > > +
> > > +_cleanup()
> > > +{
> > > +  _cleanup_test_img
> > > +  sudo rmmod null_blk
> > > +}
> > > +trap "_cleanup; exit \$status" 0 1 2 3 15
> > > +
> > > +# get standard environment, filters and checks
> > > +. ./common.rc
> > > +. ./common.filter
> > > +. ./common.qemu
> > > +
> > > +# This test only runs on Linux hosts with raw image files.
> > > +_supported_fmt raw
> > > +_supported_proto file
> > > +_supported_os Linux
> > > +
> > > +QEMU_IO="build/qemu-io"
> > > +IMG="--image-opts -n driver=zoned_host_device,filename=/dev/nullb0"
> > > +QEMU_IO_OPTIONS=$QEMU_IO_OPTIONS_NO_FMT
> > > +
> > > +echo "Testing a null_blk device:"
> > > +echo "case 1: if the operations work"
> > > +sudo modprobe null_blk nr_devices=1 zoned=1
> > > +
> > > +echo "(1) report the first zone:"
> > > +sudo $QEMU_IO $IMG -c "zrp 0 1"
> > > +echo
> > > +echo "report the first 10 zones"
> > > +sudo $QEMU_IO $IMG -c "zrp 0 10"
> > > +echo
> > > +echo "report the last zone:"
> > > +sudo $QEMU_IO $IMG -c "zrp 0x3e70000000 2" # 0x3e70000000 / 512 =
> > > 0x1f380000
> > > +echo
> > > +echo
> > > +echo "(2) opening the first zone"
> > > +sudo $QEMU_IO $IMG -c "zo 0 268435456"  # 268435456 / 512 = 524288
> > > +echo "report after:"
> > > +sudo $QEMU_IO $IMG -c "zrp 0 1"
> > > +echo
> > > +echo "opening the second zone"
> > > +sudo $QEMU_IO $IMG -c "zo 268435456 268435456" #
> > > +echo "report after:"
> > > +sudo $QEMU_IO $IMG -c "zrp 268435456 1"
> > > +echo
> > > +echo "opening the last zone"
> > > +sudo $QEMU_IO $IMG -c "zo 0x3e70000000 268435456"
> > > +echo "report after:"
> > > +sudo $QEMU_IO $IMG -c "zrp 0x3e70000000 2"
> > > +echo
> > > +echo
> > > +echo "(3) closing the first zone"
> > > +sudo $QEMU_IO $IMG -c "zc 0 268435456"
> > > +echo "report after:"
> > > +sudo $QEMU_IO $IMG -c "zrp 0 1"
> > > +echo
> > > +echo "closing the last zone"
> > > +sudo $QEMU_IO $IMG -c "zc 0x3e70000000 268435456"
> > > +echo "report after:"
> > > +sudo $QEMU_IO $IMG -c "zrp 0x3e70000000 2"
> > > +echo
> > > +echo
> > > +echo "(4) finishing the second zone"
> > > +sudo $QEMU_IO $IMG -c "zf 268435456 268435456"
> > > +echo "After finishing a zone:"
> > > +sudo $QEMU_IO $IMG -c "zrp 268435456 1"
> > > +echo
> > > +echo
> > > +echo "(5) resetting the second zone"
> > > +sudo $QEMU_IO $IMG -c "zrs 268435456 268435456"
> > > +echo "After resetting a zone:"
> > > +sudo $QEMU_IO $IMG -c "zrp 268435456 1"
> > > +
> > > +# success, all done
> > > +echo "*** done"
> > > +rm -f $seq.full
> > > +status=0
> >