* [Qemu-devel] [PATCH] docker: test-block: Don't continue if build fails
@ 2017-09-26 11:01 Fam Zheng
2017-09-26 13:48 ` Eric Blake
0 siblings, 1 reply; 3+ messages in thread
From: Fam Zheng @ 2017-09-26 11:01 UTC (permalink / raw)
To: qemu-devel; +Cc: Fam Zheng, Philippe Mathieu-Daudé, Alex Bennée
Report error and exit upon compiling error, otherwise the iotests output
will be pure noise.
Signed-off-by: Fam Zheng <famz@redhat.com>
---
tests/docker/test-block | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/docker/test-block b/tests/docker/test-block
index 2ca1ce54f6..5624b81827 100755
--- a/tests/docker/test-block
+++ b/tests/docker/test-block
@@ -14,7 +14,7 @@
cd "$BUILD_DIR"
-build_qemu --target-list=x86_64-softmmu
+build_qemu --target-list=x86_64-softmmu || test_fail "Build failed"
cd tests/qemu-iotests
for t in raw qcow2 nbd luks; do
./check -g quick -$t || test_fail "Test failed: iotests $t"
--
2.13.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] docker: test-block: Don't continue if build fails
2017-09-26 11:01 [Qemu-devel] [PATCH] docker: test-block: Don't continue if build fails Fam Zheng
@ 2017-09-26 13:48 ` Eric Blake
2017-09-27 5:47 ` Fam Zheng
0 siblings, 1 reply; 3+ messages in thread
From: Eric Blake @ 2017-09-26 13:48 UTC (permalink / raw)
To: Fam Zheng, qemu-devel; +Cc: Alex Bennée, Philippe Mathieu-Daudé
[-- Attachment #1: Type: text/plain, Size: 940 bytes --]
On 09/26/2017 06:01 AM, Fam Zheng wrote:
> Report error and exit upon compiling error, otherwise the iotests output
> will be pure noise.
>
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
> tests/docker/test-block | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
>
> diff --git a/tests/docker/test-block b/tests/docker/test-block
> index 2ca1ce54f6..5624b81827 100755
> --- a/tests/docker/test-block
> +++ b/tests/docker/test-block
> @@ -14,7 +14,7 @@
>
> cd "$BUILD_DIR"
>
> -build_qemu --target-list=x86_64-softmmu
> +build_qemu --target-list=x86_64-softmmu || test_fail "Build failed"
> cd tests/qemu-iotests
> for t in raw qcow2 nbd luks; do
> ./check -g quick -$t || test_fail "Test failed: iotests $t"
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] docker: test-block: Don't continue if build fails
2017-09-26 13:48 ` Eric Blake
@ 2017-09-27 5:47 ` Fam Zheng
0 siblings, 0 replies; 3+ messages in thread
From: Fam Zheng @ 2017-09-27 5:47 UTC (permalink / raw)
To: Eric Blake; +Cc: qemu-devel, Alex Bennée, Philippe Mathieu-Daudé
On Tue, 09/26 08:48, Eric Blake wrote:
> On 09/26/2017 06:01 AM, Fam Zheng wrote:
> > Report error and exit upon compiling error, otherwise the iotests output
> > will be pure noise.
> >
> > Signed-off-by: Fam Zheng <famz@redhat.com>
> > ---
> > tests/docker/test-block | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Reviewed-by: Eric Blake <eblake@redhat.com>
Queued, thanks.
Fam
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-09-27 5:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-26 11:01 [Qemu-devel] [PATCH] docker: test-block: Don't continue if build fails Fam Zheng
2017-09-26 13:48 ` Eric Blake
2017-09-27 5:47 ` Fam Zheng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).