From: Eric Blake <eblake@redhat.com>
To: "Markus Armbruster" <armbru@redhat.com>,
"Kővágó, Zoltán" <dirty.ice.hu@gmail.com>
Cc: qemu-devel@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [RFC PATCH] audio: proper support for float samples in mixeng
Date: Mon, 3 Feb 2020 09:34:07 -0600 [thread overview]
Message-ID: <d91dcd9f-4f6a-f2b1-bb3a-3be9966b247c@redhat.com> (raw)
In-Reply-To: <87h8086vi7.fsf@dusky.pond.sub.org>
On 2/3/20 12:21 AM, Markus Armbruster wrote:
> "Kővágó, Zoltán" <dirty.ice.hu@gmail.com> writes:
>
>> This adds proper support for float samples in mixeng by adding a new
>> audio format for it.
>>
>> Limitations: only native endianness is supported.
>>
>> Signed-off-by: Kővágó, Zoltán <DirtY.iCE.hu@gmail.com>
>> ---
>>
>> This patch is meant to be applied on top of "[PATCH] coreaudio: fix coreaudio
>> playback" by Volker Rümelin, available at:
>> https://lists.nongnu.org/archive/html/qemu-devel/2020-02/msg00114.html
>>
>> For more information, please refer to that thread.
>>
>> ---
>> +++ b/qapi/audio.json
>> @@ -276,7 +276,7 @@
>> # Since: 4.0
>> ##
>> { 'enum': 'AudioFormat',
>> - 'data': [ 'u8', 's8', 'u16', 's16', 'u32', 's32' ] }
>> + 'data': [ 'u8', 's8', 'u16', 's16', 'u32', 's32', 'f32' ] }
>>
>> ##
>> # @AudiodevDriver:
>
> For QAPI:
> Acked-by: Markus Armbruster <armbru@redhat.com>
Is it worth a comment update mentioning that 'f32' is '(since 5.0)'?
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2020-02-03 15:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-02 19:38 [RFC PATCH] audio: proper support for float samples in mixeng Kővágó, Zoltán
2020-02-02 22:14 ` Howard Spoelstra
2020-02-03 6:21 ` Markus Armbruster
2020-02-03 15:34 ` Eric Blake [this message]
2020-02-04 6:48 ` Markus Armbruster
2020-02-03 8:59 ` Volker Rümelin
2020-02-03 10:00 ` Peter Maydell
2020-02-03 20:38 ` Zoltán Kővágó
2020-02-04 10:24 ` Peter Maydell
2020-02-06 13:37 ` Gerd Hoffmann
2020-03-09 18:36 ` Alexander Bulekov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d91dcd9f-4f6a-f2b1-bb3a-3be9966b247c@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=dirty.ice.hu@gmail.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).