From: Eric Blake <eblake@redhat.com>
To: Alberto Garcia <berto@igalia.com>, qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, Kevin Wolf <kwolf@redhat.com>,
Max Reitz <mreitz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 3/7] qcow2: Check L1 table parameters in qcow2_expand_zero_clusters()
Date: Wed, 7 Mar 2018 12:47:41 -0600 [thread overview]
Message-ID: <d9268455-ae27-6818-2533-5a25a3a3439d@redhat.com> (raw)
In-Reply-To: <080ff2e2c66577e8113454dce4974c6a34915d9f.1520352600.git.berto@igalia.com>
On 03/06/2018 10:14 AM, Alberto Garcia wrote:
> This function iterates over all snapshots of a qcow2 file in order to
> expand all zero clusters, but it does not validate the snapshots' L1
> tables first.
>
> We now have a function to take care of this, so let's use it.
>
> We can also take the opportunity to replace the sector-based
> bdrv_read() with bdrv_pread().
>
> Signed-off-by: Alberto Garcia <berto@igalia.com>
> Cc: Eric Blake <eblake@redhat.com>
> ---
> block/qcow2-cluster.c | 24 +++++++++++++++++-------
> tests/qemu-iotests/080 | 2 ++
> tests/qemu-iotests/080.out | 4 ++++
> 3 files changed, 23 insertions(+), 7 deletions(-)
>
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2018-03-07 18:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-06 16:14 [Qemu-devel] [PATCH v2 0/7] Add checks for corruption in the snapshot table Alberto Garcia
2018-03-06 16:14 ` [Qemu-devel] [PATCH v2 1/7] qcow2: Generalize validate_table_offset() into qcow2_validate_table() Alberto Garcia
2018-03-06 16:14 ` [Qemu-devel] [PATCH v2 2/7] qcow2: Check L1 table offset in qcow2_snapshot_load_tmp() Alberto Garcia
2018-03-06 16:14 ` [Qemu-devel] [PATCH v2 3/7] qcow2: Check L1 table parameters in qcow2_expand_zero_clusters() Alberto Garcia
2018-03-07 18:47 ` Eric Blake [this message]
2018-03-06 16:14 ` [Qemu-devel] [PATCH v2 4/7] qcow2: Check snapshot L1 tables in qcow2_check_metadata_overlap() Alberto Garcia
2018-03-06 16:14 ` [Qemu-devel] [PATCH v2 5/7] qcow2: Check snapshot L1 table in qcow2_snapshot_goto() Alberto Garcia
2018-03-07 19:10 ` Eric Blake
2018-03-06 16:14 ` [Qemu-devel] [PATCH v2 6/7] qcow2: Check snapshot L1 table in qcow2_snapshot_delete() Alberto Garcia
2018-03-06 16:14 ` [Qemu-devel] [PATCH v2 7/7] qcow2: Make qemu-img check detect corrupted L1 tables in snapshots Alberto Garcia
2018-03-06 17:04 ` [Qemu-devel] [PATCH v2 0/7] Add checks for corruption in the snapshot table Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d9268455-ae27-6818-2533-5a25a3a3439d@redhat.com \
--to=eblake@redhat.com \
--cc=berto@igalia.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).