From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Thomas Huth <thuth@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [PATCH 2/3] meson.build: Group the network backend entries in a separate summary section
Date: Fri, 2 Jun 2023 22:03:05 +0200 [thread overview]
Message-ID: <d92bc6de-17db-96a9-096d-68b396e11128@linaro.org> (raw)
In-Reply-To: <20230602171832.533739-3-thuth@redhat.com>
On 2/6/23 19:18, Thomas Huth wrote:
> Let's make it easier for the users to spot network-related entries
> in the summary of the meson output.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> meson.build | 13 ++++++++-----
> 1 file changed, 8 insertions(+), 5 deletions(-)
>
> diff --git a/meson.build b/meson.build
> index 4a20a2e712..c64ad3c365 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -4267,13 +4267,19 @@ summary_info += {'curses support': curses}
> summary_info += {'brlapi support': brlapi}
> summary(summary_info, bool_yn: true, section: 'User interface')
>
> -# Libraries
> +# Network backends
> summary_info = {}
> if targetos == 'darwin'
> summary_info += {'vmnet.framework support': vmnet}
> endif
> -summary_info = {}
Ah, this should be squashed in the previous patch.
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> summary_info += {'slirp support': slirp}
> +summary_info += {'vde support': vde}
> +summary_info += {'netmap support': have_netmap}
> +summary_info += {'l2tpv3 support': have_l2tpv3}
> +summary(summary_info, bool_yn: true, section: 'Network backends')
> +
> +# Libraries
> +summary_info = {}
> summary_info += {'libtasn1': tasn1}
> summary_info += {'PAM': pam}
> summary_info += {'iconv support': iconv}
> @@ -4295,9 +4301,6 @@ if targetos == 'linux'
> endif
> summary_info += {'Pipewire support': pipewire}
> summary_info += {'JACK support': jack}
> -summary_info += {'vde support': vde}
> -summary_info += {'netmap support': have_netmap}
> -summary_info += {'l2tpv3 support': have_l2tpv3}
> summary_info += {'Linux AIO support': libaio}
> summary_info += {'Linux io_uring support': linux_io_uring}
> summary_info += {'ATTR/XATTR support': libattr}
next prev parent reply other threads:[~2023-06-02 20:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-02 17:18 [PATCH 0/3] meson.build: Group some entries in separate summary sections Thomas Huth
2023-06-02 17:18 ` [PATCH 1/3] meson.build: Group the UI entries in a separate summary section Thomas Huth
2023-06-02 20:01 ` Philippe Mathieu-Daudé
2023-06-02 17:18 ` [PATCH 2/3] meson.build: Group the network backend " Thomas Huth
2023-06-02 20:03 ` Philippe Mathieu-Daudé [this message]
2023-06-05 6:08 ` Thomas Huth
2023-06-02 17:18 ` [PATCH 3/3] meson.build: Group the audio " Thomas Huth
2023-06-02 20:03 ` Philippe Mathieu-Daudé
2023-06-03 3:38 ` [PATCH 0/3] meson.build: Group some entries in separate summary sections Richard Henderson
2023-06-05 8:27 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d92bc6de-17db-96a9-096d-68b396e11128@linaro.org \
--to=philmd@linaro.org \
--cc=berrange@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).