qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: WANG Xuerui <xen0n@gentoo.org>, qemu-devel@nongnu.org
Cc: "Aleksandar Rikalo" <aleksandar.rikalo@syrmia.com>,
	"Andreas K . Hüttel" <dilfridge@gentoo.org>,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	"Aurelien Jarno" <aurelien@aurel32.net>
Subject: Re: [PATCH] target/mips: Fix address space range declaration on n32
Date: Sun, 27 Mar 2022 20:40:40 -0600	[thread overview]
Message-ID: <d92dafb0-5a84-eff5-62fa-4fb7b10d0837@linaro.org> (raw)
In-Reply-To: <20220327053456.2552855-1-xen0n@gentoo.org>

On 3/26/22 23:34, WANG Xuerui wrote:
> This bug is probably lurking there for so long, I cannot even git-blame
> my way to the commit first introducing it.
> 
> Anyway, because n32 is also TARGET_MIPS64, the address space range
> cannot be determined by looking at TARGET_MIPS64 alone. Fix this by only
> declaring 48-bit address spaces for n64, or the n32 user emulation will
> happily hand out memory ranges beyond the 31-bit limit and crash.
> 
> Confirmed to make the minimal reproducing example in the linked issue
> behave.
> 
> Closes:https://gitlab.com/qemu-project/qemu/-/issues/939
> Signed-off-by: WANG Xuerui<xen0n@gentoo.org>
> Cc: Philippe Mathieu-Daudé<f4bug@amsat.org>
> Cc: Aurelien Jarno<aurelien@aurel32.net>
> Cc: Jiaxun Yang<jiaxun.yang@flygoat.com>
> Cc: Aleksandar Rikalo<aleksandar.rikalo@syrmia.com>
> Cc: Andreas K. Hüttel<dilfridge@gentoo.org>
> ---
>   target/mips/cpu-param.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

This is what I was expecting, when I read the issue report.
Thanks,

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~


      parent reply	other threads:[~2022-03-28  2:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-27  5:34 [PATCH] target/mips: Fix address space range declaration on n32 WANG Xuerui
2022-03-27 20:06 ` Andreas K. Huettel
2022-03-28  2:40 ` Richard Henderson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d92dafb0-5a84-eff5-62fa-4fb7b10d0837@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=aleksandar.rikalo@syrmia.com \
    --cc=aurelien@aurel32.net \
    --cc=dilfridge@gentoo.org \
    --cc=f4bug@amsat.org \
    --cc=qemu-devel@nongnu.org \
    --cc=xen0n@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).