From: Richard Henderson <richard.henderson@linaro.org>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>, qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: Re: [PATCH-for-5.2 3/3] hw/misc/unimp: Display the offset with width of the region size
Date: Wed, 12 Aug 2020 10:34:35 -0700 [thread overview]
Message-ID: <d95b2acb-c8e8-91cc-40fd-ed7f4890e4ab@linaro.org> (raw)
In-Reply-To: <20200807143705.30066-4-f4bug@amsat.org>
On 8/7/20 7:37 AM, Philippe Mathieu-Daudé wrote:
> + s->offset_fmt_width = ROUND_UP(64 - clz64(s->size - 1), 4) >> 2;
Better with DIV_ROUND_UP, I think. Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2020-08-12 17:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-07 14:37 [PATCH-for-5.2 0/3] hw/misc/unimp: Improve how offset/value are displayed Philippe Mathieu-Daudé
2020-08-07 14:37 ` [PATCH-for-5.2 1/3] hw/misc/unimp: Display value after offset Philippe Mathieu-Daudé
2020-08-12 17:33 ` Richard Henderson
2020-08-07 14:37 ` [PATCH-for-5.2 2/3] hw/misc/unimp: Display the value with width of the access size Philippe Mathieu-Daudé
2020-08-12 17:33 ` Richard Henderson
2020-08-07 14:37 ` [PATCH-for-5.2 3/3] hw/misc/unimp: Display the offset with width of the region size Philippe Mathieu-Daudé
2020-08-12 17:34 ` Richard Henderson [this message]
2020-08-12 18:52 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d95b2acb-c8e8-91cc-40fd-ed7f4890e4ab@linaro.org \
--to=richard.henderson@linaro.org \
--cc=f4bug@amsat.org \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).