From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7E69C35247 for ; Wed, 5 Feb 2020 17:26:37 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 75FAF217BA for ; Wed, 5 Feb 2020 17:26:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="JfRhoTWT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 75FAF217BA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:54196 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1izORg-0005VI-LM for qemu-devel@archiver.kernel.org; Wed, 05 Feb 2020 12:26:36 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:38285) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1izOIy-0008CQ-DZ for qemu-devel@nongnu.org; Wed, 05 Feb 2020 12:17:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1izOIt-00089j-87 for qemu-devel@nongnu.org; Wed, 05 Feb 2020 12:17:32 -0500 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:22975 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1izOIp-0007vH-3i for qemu-devel@nongnu.org; Wed, 05 Feb 2020 12:17:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1580923042; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+06cuhwJOrpPs/nqvWdogUh1JSYOZf7QdiLQOC+EmWQ=; b=JfRhoTWT182hCBuw+KmsmdhqBCNfxCobZk6dr9q9bRZ+dvTLKko3HrYb8F0DDkLCBae0Fj gnRYtTUj5/MHfneylXzm6QwzNO6T1jEg/od9uJ+XOH3cxE3NnY90n7Yv3HQ5vAZnmA7iDx TDYB+dajmfLR89ICQc2ChjXAGOu3y9E= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-60-Tr0ZtjB4NcWLHEDh1974kw-1; Wed, 05 Feb 2020 12:17:16 -0500 Received: by mail-wr1-f70.google.com with SMTP id u8so1495013wrp.10 for ; Wed, 05 Feb 2020 09:17:16 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=d1UTZ/afbxDcXrZJKo4vdbH5W01BYA3S7srPmxreZ+4=; b=aAdpkUiCfyIb1SCzStlhYxqViPoi3pg8+IWCM0mfbeHbb2cm38gt7nMVncMOH2/hCY kqhy42dZTwTAdQULWbpTnKgIBTs1jEfoc7hEOhn4Ng4jJZubk/qU0TptX3hWtyQdqCwf unXWZ/VviFcOp198mdMuUltmA5v1mI43vpDOSO84dSNt9OReL6u+X8vrD11NpanmgebJ maSE832zYYgDpYlN8bJZck4/Jdz/kPDIqdmY8acBZL8jN07mA7t0jbcyAtkTkCbZQocC B2TbZ3ESDqIRWB0rUkWiWZkjq9un/ijkpUOIXDGaZ9rQC0g/AcPKAuM1YIrPwBtZF7fa lVoA== X-Gm-Message-State: APjAAAUfcj/w2ycjzsMQlDlWNytE3bfQgKLQWM/cvKnSgDHNvdMLpUGw 9mOvCq5nJN0KTohZdU5fLGkxkV+86WenWkms8PKM2hFWUZkch3eHadGXun0a9CvrBTfwWguXKGE MKVVX0sV6fYU16Zw= X-Received: by 2002:adf:f6c8:: with SMTP id y8mr28813901wrp.167.1580923035540; Wed, 05 Feb 2020 09:17:15 -0800 (PST) X-Google-Smtp-Source: APXvYqymKRtkmkudc/Bjf1E9whFAMRbVqBa0mk0tDWxEZdl+vIl0aJZZbRCtFmjQzWsoiZtVMFZ64w== X-Received: by 2002:adf:f6c8:: with SMTP id y8mr28813881wrp.167.1580923035341; Wed, 05 Feb 2020 09:17:15 -0800 (PST) Received: from [192.168.1.35] (162.red-83-52-55.dynamicip.rima-tde.net. [83.52.55.162]) by smtp.gmail.com with ESMTPSA id s65sm235454wmf.48.2020.02.05.09.17.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Feb 2020 09:17:14 -0800 (PST) Subject: Re: [PATCH] qemu-img: Place the '-i aio' option in alphabetical order To: Julia Suvorova , qemu-devel@nongnu.org References: <20200205163008.204493-1-jusual@redhat.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: Date: Wed, 5 Feb 2020 18:17:12 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200205163008.204493-1-jusual@redhat.com> Content-Language: en-US X-MC-Unique: Tr0ZtjB4NcWLHEDh1974kw-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 205.139.110.61 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: QEMU Trivial , Peter Maydell , Stefan Hajnoczi Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Cc'ing qemu-trivial@ On 2/5/20 5:30 PM, Julia Suvorova wrote: > The '-i AIO' option was accidentally placed after '-n' and '-t'. Move it > after '--flush-interval'. >=20 > Signed-off-by: Julia Suvorova > --- > docs/interop/qemu-img.rst | 8 ++++---- > qemu-img-cmds.hx | 4 ++-- > 2 files changed, 6 insertions(+), 6 deletions(-) >=20 > diff --git a/docs/interop/qemu-img.rst b/docs/interop/qemu-img.rst > index fa27e5c7b4..42e4451db4 100644 > --- a/docs/interop/qemu-img.rst > +++ b/docs/interop/qemu-img.rst > @@ -247,7 +247,7 @@ Command description: > Amends the image format specific *OPTIONS* for the image file > *FILENAME*. Not all file formats support this operation. > =20 > -.. option:: bench [-c COUNT] [-d DEPTH] [-f FMT] [--flush-interval=3DFLU= SH_INTERVAL] [-n] [-i AIO] [--no-drain] [-o OFFSET] [--pattern=3DPATTERN] [= -q] [-s BUFFER_SIZE] [-S STEP_SIZE] [-t CACHE] [-w] [-U] FILENAME > +.. option:: bench [-c COUNT] [-d DEPTH] [-f FMT] [--flush-interval=3DFLU= SH_INTERVAL] [-i AIO] [-n] [--no-drain] [-o OFFSET] [--pattern=3DPATTERN] [= -q] [-s BUFFER_SIZE] [-S STEP_SIZE] [-t CACHE] [-w] [-U] FILENAME > =20 > Run a simple sequential I/O benchmark on the specified image. If ``-w= `` is > specified, a write test is performed, otherwise a read test is perfor= med. > @@ -264,13 +264,13 @@ Command description: > ``--no-drain`` is specified, a flush is issued without draining the r= equest > queue first. > =20 > + if ``-i`` is specified, *AIO* option can be used to specify different > + AIO backends: ``threads``, ``native`` or ``io_uring``. > + > If ``-n`` is specified, the native AIO backend is used if possible. O= n > Linux, this option only works if ``-t none`` or ``-t directsync`` is > specified as well. > =20 > - if ``-i`` is specified, *AIO* option can be used to specify different > - AIO backends: ``threads``, ``native`` or ``io_uring``. > - > For write tests, by default a buffer filled with zeros is written. Th= is can be > overridden with a pattern byte specified by *PATTERN*. > =20 > diff --git a/qemu-img-cmds.hx b/qemu-img-cmds.hx > index 3fd836ca90..d7fbc6b1f4 100644 > --- a/qemu-img-cmds.hx > +++ b/qemu-img-cmds.hx > @@ -16,9 +16,9 @@ SRST > ERST > =20 > DEF("bench", img_bench, > - "bench [-c count] [-d depth] [-f fmt] [--flush-interval=3Dflush_inte= rval] [-n] [--no-drain] [-o offset] [--pattern=3Dpattern] [-q] [-s buffer_s= ize] [-S step_size] [-t cache] [-i aio] [-w] [-U] filename") > + "bench [-c count] [-d depth] [-f fmt] [--flush-interval=3Dflush_inte= rval] [-i aio] [-n] [--no-drain] [-o offset] [--pattern=3Dpattern] [-q] [-s= buffer_size] [-S step_size] [-t cache] [-w] [-U] filename") > SRST > -.. option:: bench [-c COUNT] [-d DEPTH] [-f FMT] [--flush-interval=3DFLU= SH_INTERVAL] [-n] [--no-drain] [-o OFFSET] [--pattern=3DPATTERN] [-q] [-s B= UFFER_SIZE] [-S STEP_SIZE] [-t CACHE] [-i AIO] [-w] [-U] FILENAME > +.. option:: bench [-c COUNT] [-d DEPTH] [-f FMT] [--flush-interval=3DFLU= SH_INTERVAL] [-i AIO] [-n] [--no-drain] [-o OFFSET] [--pattern=3DPATTERN] [= -q] [-s BUFFER_SIZE] [-S STEP_SIZE] [-t CACHE] [-w] [-U] FILENAME > ERST > DEF("check", img_check, > "check [--object objectdef] [--image-opts] [-q] [-f fmt] [--output= =3Dofmt] [-r [leaks | all]] [-T src_cache] [-U] filename") >=20 Reviewed-by: Philippe Mathieu-Daud=C3=A9