Re: [PATCH for-7.0 v5] qemu-binfmt-conf.sh: mips: allow nonzero EI_ABIVERSION, distinguish o32 and n32

[Laurent Vivier <laurent@vivier.eu>]

Le 29/03/2022 à 01:39, Philippe Mathieu-Daudé a écrit :
> On 28/3/22 22:49, Andreas K. Hüttel wrote:
>> With the command line flag -mplt and a recent toolchain, ELF binaries
>> generated by gcc can obtain EI_ABIVERSION=1, which makes, e.g., gcc
>> three-stage bootstrap in a mips-unknown-linux-gnu qemu-user chroot
>> fail since the binfmt-misc magic does not match anymore. Also other
>> values are technically possible. qemu executes these binaries just
>> fine, so relax the mask for the EI_ABIVERSION byte at offset 0x08.
>>
>> In addition, extend magic string to distinguish mips o32 and n32 ABI.
>> This information is given by the EF_MIPS_ABI2 (0x20) bit in the
>> e_flags field of the ELF header (a 4-byte value at offset 0x24 for
>> the here applicable ELFCLASS32).
>>
>> See-also: ace3d65459
>> Signed-off-by: Andreas K. Hüttel <dilfridge@gentoo.org>
>> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>> Reviewed-by: WANG Xuerui <xen0n@gentoo.org>
> 
> v5 changes are too different from v4 to keep these R-b tags IMO.
> 
> LGTM but I'd like Xuerui to double-check the R-b stands,
> and an Acked-by from Laurent would make me feel safer ;)

Sorry, I didn't see your email before.
It's more mips than linux-user, so there is no problem for me.

Thanks,
Laurent