From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Cc: "Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [PATCH v3 04/20] plugins: Move function pointer in qemu_plugin_dyn_cb
Date: Mon, 29 Apr 2024 12:58:30 +0200 [thread overview]
Message-ID: <d98feb5e-8dcf-41c8-a0a2-a0246f6649fe@linaro.org> (raw)
In-Reply-To: <20240424230224.941028-5-richard.henderson@linaro.org>
On 25/4/24 01:02, Richard Henderson wrote:
> The out-of-line function pointer is mutually exclusive
> with inline expansion, so move it into the union.
> Wrap the pointer in a structure named 'regular' to match
> PLUGIN_CB_REGULAR.
>
> Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> include/qemu/plugin.h | 4 +++-
> accel/tcg/plugin-gen.c | 4 ++--
> plugins/core.c | 8 ++++----
> 3 files changed, 9 insertions(+), 7 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2024-04-29 10:59 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-24 23:02 [PATCH v3 00/20] Rewrite plugin code generation Richard Henderson
2024-04-24 23:02 ` [PATCH v3 01/20] tcg: Make tcg/helper-info.h self-contained Richard Henderson
2024-04-29 10:57 ` Philippe Mathieu-Daudé
2024-04-24 23:02 ` [PATCH v3 02/20] tcg: Pass function pointer to tcg_gen_call* Richard Henderson
2024-04-29 11:00 ` Philippe Mathieu-Daudé
2024-04-24 23:02 ` [PATCH v3 03/20] plugins: Zero new qemu_plugin_dyn_cb entries Richard Henderson
2024-04-24 23:02 ` [PATCH v3 04/20] plugins: Move function pointer in qemu_plugin_dyn_cb Richard Henderson
2024-04-29 10:58 ` Philippe Mathieu-Daudé [this message]
2024-04-24 23:02 ` [PATCH v3 05/20] plugins: Create TCGHelperInfo for all out-of-line callbacks Richard Henderson
2024-04-24 23:02 ` [PATCH v3 06/20] plugins: Use emit_before_op for PLUGIN_GEN_AFTER_INSN Richard Henderson
2024-04-29 19:56 ` Pierrick Bouvier
2024-04-24 23:02 ` [PATCH v3 07/20] plugins: Use emit_before_op for PLUGIN_GEN_FROM_TB Richard Henderson
2024-04-29 19:57 ` Pierrick Bouvier
2024-04-24 23:02 ` [PATCH v3 08/20] plugins: Add PLUGIN_GEN_AFTER_TB Richard Henderson
2024-04-24 23:02 ` [PATCH v3 09/20] plugins: Use emit_before_op for PLUGIN_GEN_FROM_INSN Richard Henderson
2024-04-24 23:02 ` [PATCH v3 10/20] plugins: Use emit_before_op for PLUGIN_GEN_FROM_MEM Richard Henderson
2024-04-24 23:02 ` [PATCH v3 11/20] plugins: Remove plugin helpers Richard Henderson
2024-04-24 23:02 ` [PATCH v3 12/20] tcg: Remove TCG_CALL_PLUGIN Richard Henderson
2024-04-24 23:02 ` [PATCH v3 13/20] tcg: Remove INDEX_op_plugin_cb_{start,end} Richard Henderson
2024-04-24 23:02 ` [PATCH v3 14/20] plugins: Simplify callback queues Richard Henderson
2024-04-24 23:02 ` [PATCH v3 15/20] plugins: Introduce PLUGIN_CB_MEM_REGULAR Richard Henderson
2024-04-24 23:02 ` [PATCH v3 16/20] plugins: Replace pr_ops with a proper debug dump flag Richard Henderson
2024-04-24 23:02 ` [PATCH v3 17/20] plugins: Split out common cb expanders Richard Henderson
2024-04-24 23:02 ` [PATCH v3 18/20] plugins: Merge qemu_plugin_tb_insn_get to plugin-gen.c Richard Henderson
2024-04-24 23:02 ` [PATCH v3 19/20] plugins: Inline plugin_gen_empty_callback Richard Henderson
2024-04-24 23:02 ` [PATCH v3 20/20] plugins: Update the documentation block for plugin-gen.c Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d98feb5e-8dcf-41c8-a0a2-a0246f6649fe@linaro.org \
--to=philmd@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).