From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49374) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bsW1K-0002nz-77 for qemu-devel@nongnu.org; Fri, 07 Oct 2016 10:21:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bsW1I-0002A9-2Y for qemu-devel@nongnu.org; Fri, 07 Oct 2016 10:21:05 -0400 References: <307c86b73ddfd22d56c41ad0ee700a7c070c73f0.1475812005.git.jcody@redhat.com> From: Eric Blake Message-ID: Date: Fri, 7 Oct 2016 09:20:54 -0500 MIME-Version: 1.0 In-Reply-To: <307c86b73ddfd22d56c41ad0ee700a7c070c73f0.1475812005.git.jcody@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="aBTalkmeEgKi2LKW8T9Wu1F9oD6d4Oc7L" Subject: Re: [Qemu-devel] [PATCH 1/1] block: add gluster ifdef guard checks for SEEK_DATA/SEEK_HOLE support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jeff Cody , qemu-devel@nongnu.org Cc: qemu-block@nongnu.org, ndevos@redhat.com, pkalever@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --aBTalkmeEgKi2LKW8T9Wu1F9oD6d4Oc7L From: Eric Blake To: Jeff Cody , qemu-devel@nongnu.org Cc: qemu-block@nongnu.org, ndevos@redhat.com, pkalever@redhat.com Message-ID: Subject: Re: [PATCH 1/1] block: add gluster ifdef guard checks for SEEK_DATA/SEEK_HOLE support References: <307c86b73ddfd22d56c41ad0ee700a7c070c73f0.1475812005.git.jcody@redhat.com> In-Reply-To: <307c86b73ddfd22d56c41ad0ee700a7c070c73f0.1475812005.git.jcody@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10/06/2016 10:53 PM, Jeff Cody wrote: > Add checks to see if the system compiling QEMU has support for > SEEK_HOLE/SEEK_DATA. If the system does not, we will flag that seek > data is unsupported in gluster. >=20 > Note: this is not a check on whether the gluster server itself supports= > SEEK_DATA (that is already done during runtime), but rather if the > compilation environment supports SEEK_DATA. >=20 > Signed-off-by: Jeff Cody > --- >=20 > Note: this patch is untested on older systems that do not support SEEK_= DATA > (e.g.. RHEL6). This won't be pulled into my tree until it is verified.= >=20 CC block/gluster.o block/gluster.c: In function =E2=80=98qemu_gluster_test_seek=E2=80=99: block/gluster.c:676: warning: unused variable =E2=80=98eof=E2=80=99 block/gluster.c: In function =E2=80=98find_allocation=E2=80=99: block/gluster.c:1188: warning: unused variable =E2=80=98offs=E2=80=99 but compilation succeeded in spite of the warning. Would be nice to clean that up for -Werror users. Tested-by: Eric Blake Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --aBTalkmeEgKi2LKW8T9Wu1F9oD6d4Oc7L Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJX969GAAoJEKeha0olJ0NqkJMIAI85KYAVe3Z2hA7CuGPNU95P H3vcftC41j9ZDdVCFotQxX0wynT48e8qCqQrMq9ofVGe2ozmwzQU9NkagQDGxGnh 7QWLof/qa9q2g6p05jkvfr451lx6xLsxqkC3/T//gUMUJBjXAa+s0y6rW0D+3LZy cRLbJGgI6KfAinDCevdXaos5tlLHgaLtkYItb0keq8BgKzV9MKxj8o0iAjKmQBia f+lTFMAh8dXl2G9ubQEGVcTSW4tyDCxjB83htacbCoErtlOSBNxzdVJeEZkn4p6W vVavl4QB1WouPDuSz7CCrIOStWmBLuWu4vTTegC8O5F8GfId2ofAbefseSwY3YU= =F4Dc -----END PGP SIGNATURE----- --aBTalkmeEgKi2LKW8T9Wu1F9oD6d4Oc7L--