Re: [Qemu-devel] [PATCH v4 18/18] block: pass option prefix down to crypto layer

[Max Reitz <mreitz@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 982 bytes --]

On 10.02.2017 18:09, Daniel P. Berrange wrote:
> While the crypto layer uses a fixed option name "key-secret",
> the upper block layer may have a prefix on the options. e.g.
> "luks-key-secret", "aes-key-secret", in order to avoid clashes
> between crypto option names & other block option names. To
> ensure the crypto layer can report accurate error messages,
> we must tell it what option name prefix was used.
> 
> Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
> ---
>  block/crypto.c            |  4 ++--
>  block/qcow.c              |  7 ++++---
>  block/qcow2.c             | 15 +++++++++------
>  crypto/block-luks.c       |  8 ++++++--
>  crypto/block-qcow.c       |  8 ++++++--
>  crypto/block.c            |  6 ++++--
>  crypto/blockpriv.h        |  2 ++
>  include/crypto/block.h    |  6 +++++-
>  tests/test-crypto-block.c |  8 ++++----
>  9 files changed, 42 insertions(+), 22 deletions(-)

Reviewed-by: Max Reitz <mreitz@redhat.com>


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 512 bytes --]