From: Max Reitz <mreitz@redhat.com>
To: John Snow <jsnow@redhat.com>, BALATON Zoltan <balaton@eik.bme.hu>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
Qemu-block <qemu-block@nongnu.org>
Subject: Coverity CID 1421984
Date: Mon, 23 Mar 2020 12:46:03 +0100 [thread overview]
Message-ID: <d9b7d8d8-1640-7d69-cd16-66e6d9cef3d1@redhat.com> (raw)
[-- Attachment #1.1: Type: text/plain, Size: 585 bytes --]
Hi,
I was triaging new Coverity block layer reports today, and one that
seemed like a real bug was CID 1421984:
It complains about a memleak in sii3112_pci_realize() in
hw/ide/sii3112.c, specifically about @irq being leaked (it’s allocated
by qemu_allocate_irqs(), but never put anywhere or freed).
I’m not really well-versed in anything under hw/ide, so I was wondering
whether you agree it’s a bug and whether you know the correct way to fix
it. (I assume it’s just a g_free(irqs), but maybe there’s a more
specific way that’s applicable here.)
Max
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next reply other threads:[~2020-03-23 11:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-23 11:46 Max Reitz [this message]
2020-03-23 11:58 ` Coverity CID 1421984 Philippe Mathieu-Daudé
2020-03-23 13:11 ` BALATON Zoltan
2020-03-23 13:26 ` Max Reitz
2020-03-23 13:35 ` Peter Maydell
2020-03-23 14:06 ` BALATON Zoltan
2020-03-23 14:35 ` Peter Maydell
2020-03-23 14:43 ` BALATON Zoltan
2020-03-23 14:46 ` Peter Maydell
2020-03-23 15:28 ` BALATON Zoltan
2020-03-23 15:33 ` Peter Maydell
2020-03-23 15:28 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d9b7d8d8-1640-7d69-cd16-66e6d9cef3d1@redhat.com \
--to=mreitz@redhat.com \
--cc=balaton@eik.bme.hu \
--cc=jsnow@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).