From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MoQzF-0006vd-94
	for qemu-devel@nongnu.org; Thu, 17 Sep 2009 20:06:05 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MoQzA-0006vR-TY
	for qemu-devel@nongnu.org; Thu, 17 Sep 2009 20:06:05 -0400
Received: from [199.232.76.173] (port=39029 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MoQzA-0006vO-O1
	for qemu-devel@nongnu.org; Thu, 17 Sep 2009 20:06:00 -0400
Received: from mail-fx0-f211.google.com ([209.85.220.211]:34259)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <dustin.kirkland@gmail.com>) id 1MoQzA-0000zw-7h
	for qemu-devel@nongnu.org; Thu, 17 Sep 2009 20:06:00 -0400
Received: by fxm7 with SMTP id 7so396518fxm.34
	for <qemu-devel@nongnu.org>; Thu, 17 Sep 2009 17:05:58 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <4AB254FC.6080102@codemonkey.ws>
References: <2ca5c65a0909170409n67e97785p31f5d2d58cbe5058@mail.gmail.com>
	<4AB254FC.6080102@codemonkey.ws>
Date: Thu, 17 Sep 2009 19:05:58 -0500
Message-ID: <d9c105ea0909171705p47ba9146j90f4d8e0ec0a365c@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH] Set SDL icon_title when using `-name XXX`
	for proper gnome-panel window list integration
From: Dustin Kirkland <dustin.kirkland@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Dominic Evans <oldmanuk@gmail.com>, qemu-devel@nongnu.org

On Thu, Sep 17, 2009 at 10:25 AM, Anthony Liguori <anthony@codemonkey.ws> wrote:
> Dominic Evans wrote:
>>
>> qemu: improve sdl title information
>>
>> Include the `-name XXX` commandline param in the gnome-panel window list
>> via icon_title.
>>
>> https://bugs.edge.launchpad.net/ubuntu/+source/qemu-kvm/+bug/423076
>>
>
> Please include a Signed-off-by.

Hmm, I tested this patch for inclusion in Ubuntu.  It seems to work (-name foo).

However, it seems to either break, or expose a bug in libvirt:

Traceback (most recent call last):
  File "/usr/share/virt-manager/virtManager/engine.py", line 493, in run_domain
    vm.startup()
  File "/usr/share/virt-manager/virtManager/domain.py", line 558, in startup
    self.vm.create()
  File "/usr/lib/python2.6/dist-packages/libvirt.py", line 293, in create
    if ret == -1: raise libvirtError ('virDomainCreate() failed', dom=self)
libvirtError: internal error unable to start guest: /usr/bin/kvm:
invalid option -- '-domid'

I haven't quite made sense of this yet...  -domid is not a valid
parameter in kvm, sure.  However, when launching VM's in virt-manager
with this patch, this is the behavior I'm seeing...

:-Dustin