From: Dustin Kirkland <kirkland@canonical.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Dominic Evans <oldmanuk@gmail.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Set SDL icon_title when using `-name XXX` for proper gnome-panel window list integration
Date: Fri, 18 Sep 2009 10:59:31 -0500 [thread overview]
Message-ID: <d9c105ea0909180859xcdef005qb235f3e7c313895@mail.gmail.com> (raw)
In-Reply-To: <d9c105ea0909171705p47ba9146j90f4d8e0ec0a365c@mail.gmail.com>
On Thu, Sep 17, 2009 at 7:05 PM, Dustin Kirkland
<dustin.kirkland@gmail.com> wrote:
> On Thu, Sep 17, 2009 at 10:25 AM, Anthony Liguori <anthony@codemonkey.ws> wrote:
>> Dominic Evans wrote:
>>>
>>> qemu: improve sdl title information
>>>
>>> Include the `-name XXX` commandline param in the gnome-panel window list
>>> via icon_title.
>>>
>>> https://bugs.edge.launchpad.net/ubuntu/+source/qemu-kvm/+bug/423076
>>>
>>
>> Please include a Signed-off-by.
>
> Hmm, I tested this patch for inclusion in Ubuntu. It seems to work (-name foo).
>
> However, it seems to either break, or expose a bug in libvirt:
>
> Traceback (most recent call last):
> File "/usr/share/virt-manager/virtManager/engine.py", line 493, in run_domain
> vm.startup()
> File "/usr/share/virt-manager/virtManager/domain.py", line 558, in startup
> self.vm.create()
> File "/usr/lib/python2.6/dist-packages/libvirt.py", line 293, in create
> if ret == -1: raise libvirtError ('virDomainCreate() failed', dom=self)
> libvirtError: internal error unable to start guest: /usr/bin/kvm:
> invalid option -- '-domid'
>
> I haven't quite made sense of this yet... -domid is not a valid
> parameter in kvm, sure. However, when launching VM's in virt-manager
> with this patch, this is the behavior I'm seeing...
Sorry, I take this back. My testing was not in a clean environment.
Dominic's patch works for me. I'm adding it to the Ubuntu qemu-kvm
package. Hopefully it will be accepted upstream for 0.12.
Tested-by: Dustin Kirkland <kirkland@canonical.com>
next prev parent reply other threads:[~2009-09-18 15:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-17 11:09 [Qemu-devel] [PATCH] Set SDL icon_title when using `-name XXX` for proper gnome-panel window list integration Dominic Evans
2009-09-17 15:25 ` Anthony Liguori
2009-09-18 0:05 ` Dustin Kirkland
2009-09-18 15:59 ` Dustin Kirkland [this message]
2009-09-24 11:13 ` Dominic Evans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d9c105ea0909180859xcdef005qb235f3e7c313895@mail.gmail.com \
--to=kirkland@canonical.com \
--cc=anthony@codemonkey.ws \
--cc=oldmanuk@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).