From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Mofs6-0005EI-63
	for qemu-devel@nongnu.org; Fri, 18 Sep 2009 11:59:42 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Mofrz-0005Dq-NJ
	for qemu-devel@nongnu.org; Fri, 18 Sep 2009 11:59:40 -0400
Received: from [199.232.76.173] (port=49214 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Mofrz-0005Dn-IJ
	for qemu-devel@nongnu.org; Fri, 18 Sep 2009 11:59:35 -0400
Received: from mail-bw0-f211.google.com ([209.85.218.211]:65181)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <dustin.kirkland@gmail.com>) id 1Mofrz-0000LP-3R
	for qemu-devel@nongnu.org; Fri, 18 Sep 2009 11:59:35 -0400
Received: by bwz7 with SMTP id 7so770456bwz.34
	for <qemu-devel@nongnu.org>; Fri, 18 Sep 2009 08:59:32 -0700 (PDT)
MIME-Version: 1.0
Sender: dustin.kirkland@gmail.com
In-Reply-To: <d9c105ea0909171705p47ba9146j90f4d8e0ec0a365c@mail.gmail.com>
References: <2ca5c65a0909170409n67e97785p31f5d2d58cbe5058@mail.gmail.com>
	<4AB254FC.6080102@codemonkey.ws>
	<d9c105ea0909171705p47ba9146j90f4d8e0ec0a365c@mail.gmail.com>
Date: Fri, 18 Sep 2009 10:59:31 -0500
Message-ID: <d9c105ea0909180859xcdef005qb235f3e7c313895@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH] Set SDL icon_title when using `-name XXX`
	for proper gnome-panel window list integration
From: Dustin Kirkland <kirkland@canonical.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Dominic Evans <oldmanuk@gmail.com>, qemu-devel@nongnu.org

On Thu, Sep 17, 2009 at 7:05 PM, Dustin Kirkland
<dustin.kirkland@gmail.com> wrote:
> On Thu, Sep 17, 2009 at 10:25 AM, Anthony Liguori <anthony@codemonkey.ws>=
 wrote:
>> Dominic Evans wrote:
>>>
>>> qemu: improve sdl title information
>>>
>>> Include the `-name XXX` commandline param in the gnome-panel window lis=
t
>>> via icon_title.
>>>
>>> https://bugs.edge.launchpad.net/ubuntu/+source/qemu-kvm/+bug/423076
>>>
>>
>> Please include a Signed-off-by.
>
> Hmm, I tested this patch for inclusion in Ubuntu. =A0It seems to work (-n=
ame foo).
>
> However, it seems to either break, or expose a bug in libvirt:
>
> Traceback (most recent call last):
> =A0File "/usr/share/virt-manager/virtManager/engine.py", line 493, in run=
_domain
> =A0 =A0vm.startup()
> =A0File "/usr/share/virt-manager/virtManager/domain.py", line 558, in sta=
rtup
> =A0 =A0self.vm.create()
> =A0File "/usr/lib/python2.6/dist-packages/libvirt.py", line 293, in creat=
e
> =A0 =A0if ret =3D=3D -1: raise libvirtError ('virDomainCreate() failed', =
dom=3Dself)
> libvirtError: internal error unable to start guest: /usr/bin/kvm:
> invalid option -- '-domid'
>
> I haven't quite made sense of this yet... =A0-domid is not a valid
> parameter in kvm, sure. =A0However, when launching VM's in virt-manager
> with this patch, this is the behavior I'm seeing...

Sorry, I take this back.  My testing was not in a clean environment.

Dominic's patch works for me.  I'm adding it to the Ubuntu qemu-kvm
package.  Hopefully it will be accepted upstream for 0.12.

Tested-by: Dustin Kirkland <kirkland@canonical.com>