From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Ben Widawsky <ben.widawsky@intel.com>, qemu-devel@nongnu.org
Cc: "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH 1/2] pci: Change error_report to assert(3)
Date: Thu, 15 Oct 2020 21:55:24 +0200 [thread overview]
Message-ID: <d9c27793-7686-5bf3-bf5a-74800311657b@redhat.com> (raw)
In-Reply-To: <20201015181411.89104-1-ben.widawsky@intel.com>
On 10/15/20 8:14 PM, Ben Widawsky wrote:
> Asserts are used for developer bugs. As registering a bar of the wrong
> size is not something that should be possible for a user to achieve,
> this is a developer bug.
>
> While here, use the more obvious helper function.
>
> Signed-off-by: Ben Widawsky <ben.widawsky@intel.com>
> ---
> hw/pci/pci.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
next prev parent reply other threads:[~2020-10-15 19:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-15 18:14 [PATCH 1/2] pci: Change error_report to assert(3) Ben Widawsky
2020-10-15 18:14 ` [PATCH v2 2/2] pci: Disallow improper BAR registration for type 1 Ben Widawsky
2020-10-15 19:55 ` Philippe Mathieu-Daudé [this message]
2020-10-15 19:57 ` [PATCH 1/2] pci: Change error_report to assert(3) Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d9c27793-7686-5bf3-bf5a-74800311657b@redhat.com \
--to=philmd@redhat.com \
--cc=ben.widawsky@intel.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).