From: Thomas Huth <thuth@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-arm <qemu-arm@nongnu.org>,
Richard Henderson <richard.henderson@linaro.org>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [PATCH] disas/libvixl: Fix fall-through annotation for GCC >= 7
Date: Mon, 24 Aug 2020 16:03:09 +0200 [thread overview]
Message-ID: <d9cd17bc-76da-89e1-d455-72d688e21cc7@redhat.com> (raw)
In-Reply-To: <CAFEAcA97pa2eUx2-c-YmuBGaVA9jUDZ-VTd5fCpcyJ1rigiEww@mail.gmail.com>
On 24/08/2020 15.18, Peter Maydell wrote:
> On Mon, 24 Aug 2020 at 14:01, Thomas Huth <thuth@redhat.com> wrote:
>>
>> For compiling with -Wimplicit-fallthrough we need to fix the
>> fallthrough annotations in the libvixl code. This is based on
>> the following upstream vixl commit by Martyn Capewell:
>>
>> https://git.linaro.org/arm/vixl.git/commit/?id=de326f850f736c3a337
>>
>> "GCC 7 enables switch/case fallthrough checking, but this fails in
>> VIXL, because the annotation we use is Clang specific.
>>
>> Also, fix a missing annotation in the disassembler."
>
> Maybe I should just update us to a newer upstream vixl...
That would certainly be nice, too.
Thomas
next prev parent reply other threads:[~2020-08-24 14:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-24 13:01 [PATCH] disas/libvixl: Fix fall-through annotation for GCC >= 7 Thomas Huth
2020-08-24 13:18 ` Peter Maydell
2020-08-24 14:03 ` Thomas Huth [this message]
2020-08-26 6:07 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d9cd17bc-76da-89e1-d455-72d688e21cc7@redhat.com \
--to=thuth@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).