From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F2EBEC433F5 for ; Tue, 15 Mar 2022 21:42:19 +0000 (UTC) Received: from localhost ([::1]:60190 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nUEvq-0006q9-Ok for qemu-devel@archiver.kernel.org; Tue, 15 Mar 2022 17:42:18 -0400 Received: from eggs.gnu.org ([209.51.188.92]:36482) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nUEu6-0005JU-EW for qemu-devel@nongnu.org; Tue, 15 Mar 2022 17:40:30 -0400 Received: from [2607:f8b0:4864:20::1032] (port=51767 helo=mail-pj1-x1032.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nUEu3-0000h7-Kp for qemu-devel@nongnu.org; Tue, 15 Mar 2022 17:40:30 -0400 Received: by mail-pj1-x1032.google.com with SMTP id gb19so598720pjb.1 for ; Tue, 15 Mar 2022 14:40:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=hjXGVo064wjC8rfuvzgfaCnjYZ+5mWz2t70gVDLXNMQ=; b=oWQX0gu2PiUWxMdgOx+y8q6EGVr1Q1BcOUss3gT61W2FQFtLTtGFudF5s2p1vNREse 8AAAzgJHDHXJTL2NCKSr+5mQJe9WG0hmUCF0GQHum9lwkCuCVwkvdvaXhQwTEsNhqWTm cZdKbukcajgs04sTF3Nlyl8V38iL6T4QlokanFbOvJGMhyOiqQYWyrMoVGCcRzPWC4DO 0mqWnJ7Q0KSycXDpjfT50Kw84gM/tN3VWoPHt9nPGScBS9O5QvDrHV+kqED8oWAp3Uko XR+N3qu9Hwy6xE4+Nmk2+zMuQmAbnAB9rGZqgz/41+BQEmLn/xXmBobPj0VpAj6Ld0f1 tvEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=hjXGVo064wjC8rfuvzgfaCnjYZ+5mWz2t70gVDLXNMQ=; b=r/scshZqXRkI4YtFVWjDE16kYJvMbkMRKxpZ/hR3mvRio579TsXWkOH1eNcRLWVyaU TvSHS6xQZejEFo9Nes8GPxC63t8uaPo4a/WYzd33T2aIAEgfSIcNP1W+ERdBHSKOB+O0 jLU56VPbGl2dqmoFpX105Q2k684NPeTqDvy0b6DVrNHKTIdqq0m0AxfiMpZ0QyhEXns1 atO1FPdjWjEjQQIxbOb3wXYPhfaxLuIQUVz9uMr4btXPGTqx2gfWjVA1CRkkiEnTnw6P WelqURFH1wWy1VgyoxvnvcNEnon1fMI8v5dIBQbGc34z3E2fzTF0JKBHMsIkbcgY3SLi 92fQ== X-Gm-Message-State: AOAM531cSBibRN/n8mFGHs0WOGwfnrmvA3JZCrlfsj387ODVaXmJLExA niSsetBpCtUq5cNTW4x2K+djtw== X-Google-Smtp-Source: ABdhPJx4D4kq6YixcFS/hT7/jU0Ba4JGVtgufXO02fWuId6dEI7WQbJGIM3c08/JqShVwi8H8xvvrA== X-Received: by 2002:a17:90a:3e42:b0:1bf:53ce:f1ef with SMTP id t2-20020a17090a3e4200b001bf53cef1efmr6794382pjm.33.1647380425790; Tue, 15 Mar 2022 14:40:25 -0700 (PDT) Received: from [192.168.1.6] (174-21-142-130.tukw.qwest.net. [174.21.142.130]) by smtp.gmail.com with ESMTPSA id v7-20020a637a07000000b0037c9268a310sm199135pgc.3.2022.03.15.14.40.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Mar 2022 14:40:25 -0700 (PDT) Message-ID: Date: Tue, 15 Mar 2022 14:40:23 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH 1/2] target/arm: Log M-profile vector table accesses Content-Language: en-US To: Peter Maydell , qemu-arm@nongnu.org, qemu-devel@nongnu.org References: <20220315204306.2797684-1-peter.maydell@linaro.org> <20220315204306.2797684-2-peter.maydell@linaro.org> From: Richard Henderson In-Reply-To: <20220315204306.2797684-2-peter.maydell@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::1032 (failed) Received-SPF: pass client-ip=2607:f8b0:4864:20::1032; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1032.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 3/15/22 13:43, Peter Maydell wrote: > Currently the CPU_LOG_INT logging misses some useful information > about loads from the vector table. Add logging where we load vector > table entries. This is particularly helpful for cases where the user > has accidentally not put a vector table in their image at all, which > can result in confusing guest crashes at startup. > > Here's an example of the new logging for a case where > the vector table contains garbage: > > Loaded reset SP 0x0 PC 0x0 from vector table > Loaded reset SP 0xd008f8df PC 0xf000bf00 from vector table > Taking exception 3 [Prefetch Abort] on CPU 0 > ...with CFSR.IACCVIOL > ...BusFault with BFSR.STKERR > ...taking pending nonsecure exception 3 > ...loading from element 3 of non-secure vector table at 0xc > ...loaded new PC 0x20000558 > ---------------- > IN: > 0x20000558: 08000079 stmdaeq r0, {r0, r3, r4, r5, r6} > > (The double reset logging is the result of our long-standing > "CPUs all get reset twice" weirdness; it looks a bit ugly > but it'll go away if we ever fix that :-)) > > Signed-off-by: Peter Maydell > --- > target/arm/cpu.c | 5 +++++ > target/arm/m_helper.c | 5 +++++ > 2 files changed, 10 insertions(+) Reviewed-by: Richard Henderson r~