From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>, Thomas Huth <thuth@redhat.com>
Cc: "Hervé Poussineau" <hpoussin@reactos.org>,
"QEMU Developers" <qemu-devel@nongnu.org>,
qemu-ppc@nongnu.org, "David Gibson" <david@gibson.dropbear.id.au>,
"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
"Fam Zheng" <famz@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] hw/ppc/prep: Fix implicit creation of "-drive if=scsi" devices
Date: Thu, 8 Mar 2018 18:51:53 +0100 [thread overview]
Message-ID: <d9f23e85-4b88-f94a-987d-3214d37c7ff4@redhat.com> (raw)
In-Reply-To: <CAFEAcA8mYKZ7F0YE8=x-4Y8Ca9dn3GEOTNg0iV6U53ZvH1fL5g@mail.gmail.com>
On 08/03/2018 11:45, Peter Maydell wrote:
> On 8 March 2018 at 10:26, Thomas Huth <thuth@redhat.com> wrote:
>> The problem is rather that we still need more automatic regression tests
>> for stuff like this. I already have got something in mind for a new
>> qtest: If "mkisofs" or "genisoimage" is available, we could create a
>> boot CD-ROM automatically using the boot code from tests/boot-sector.c.
>> Then the test could try to boot from that CD-ROM to check whether
>> "--cdrom" is still working as expected. What do you think, does that
>> sound reasonable?
>
> That's probably a good plan, though it wouldn't be able to cover
> boards like versatile/realview that can't boot from a cdrom.
We don't need to boot, we "only" need to have a qtest that sends an
INQUIRY command. The code to bring up the LSI HBA can be copied from
SeaBIOS, what's missing is libqos ports for the various PCI bridges...
Paolo
next prev parent reply other threads:[~2018-03-08 17:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-07 9:08 [Qemu-devel] [PATCH] hw/ppc/prep: Fix implicit creation of "-drive if=scsi" devices Thomas Huth
2018-03-08 2:04 ` David Gibson
2018-03-08 6:58 ` Hervé Poussineau
2018-03-08 7:09 ` Thomas Huth
2018-03-08 10:07 ` Peter Maydell
2018-03-08 10:26 ` Thomas Huth
2018-03-08 10:45 ` Peter Maydell
2018-03-08 17:51 ` Paolo Bonzini [this message]
2018-03-08 8:02 ` Hervé Poussineau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d9f23e85-4b88-f94a-987d-3214d37c7ff4@redhat.com \
--to=pbonzini@redhat.com \
--cc=armbru@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=famz@redhat.com \
--cc=hpoussin@reactos.org \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).