From: Eric Blake <eblake@redhat.com>
To: Thomas Huth <thuth@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>,
Paolo Bonzini <pbonzini@redhat.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [PULL 00/10] Gitlab-CI, qtest, moxie removal and misc patches
Date: Fri, 7 May 2021 07:53:04 -0500 [thread overview]
Message-ID: <da0b1f8a-669c-3998-c3a3-a4660d6867b8@redhat.com> (raw)
In-Reply-To: <66206f67-f3c8-eb1c-fd5d-8c7555fe5316@redhat.com>
On 5/6/21 2:00 AM, Thomas Huth wrote:
> D'oh! I think I can work-around the problem with a patch like
> this on top:
>
> diff a/configure b/configure
> --- a/configure
> +++ b/configure
> @@ -1686,6 +1686,11 @@ fi
>
> for config in $mak_wilds; do
> target="$(basename "$config" .mak)"
> + if [ "$target" = "moxie-softmmu" ]; then
> + # This is a work-around to make incremental builds pass after
> + # moxie-softmmu has been removed. It can be removed later.
> + continue
> + fi
> if echo "$target_list_exclude" | grep -vq "$target"; then
> default_target_list="${default_target_list} $target"
> fi
> diff a/default-configs/targets/moxie-softmmu.mak
> b/default-configs/targets/moxie-softmmu.mak
> new file mode 100644
> index 0000000000..23fd596b66
> --- /dev/null
> +++ b/default-configs/targets/moxie-softmmu.mak
> @@ -0,0 +1,2 @@
> +# This is just a dummy file to avoid that incremental builds are failing.
s/to avoid that incremental builds are failing/to avoid incremental
build failures/
> +# It can be removed as soon as all builders have been updated.
>
> Does that look acceptable? If yes, I'll respin my PR with that
> squashed into the moxie patch.
>
> Thomas
>
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
prev parent reply other threads:[~2021-05-07 12:55 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-03 10:44 [PULL 00/10] Gitlab-CI, qtest, moxie removal and misc patches Thomas Huth
2021-05-03 10:44 ` [PULL 01/10] Remove the deprecated moxie target Thomas Huth
2021-05-03 10:44 ` [PULL 02/10] tests/docker/dockerfiles: Add ccache to containers where it was missing Thomas Huth
2021-05-03 10:44 ` [PULL 03/10] include/sysemu: Poison all accelerator CONFIG switches in common code Thomas Huth
2021-05-03 10:44 ` [PULL 04/10] gitlab-ci: Replace YAML anchors by extends (container_job) Thomas Huth
2021-05-03 10:44 ` [PULL 05/10] gitlab-ci: Replace YAML anchors by extends (native_build_job) Thomas Huth
2021-05-03 10:44 ` [PULL 06/10] gitlab-ci: Replace YAML anchors by extends (native_test_job) Thomas Huth
2021-05-03 10:44 ` [PULL 07/10] libqos/qgraph: fix "UNAVAILBLE" typo Thomas Huth
2021-05-03 10:44 ` [PULL 08/10] docs/devel/qgraph: add troubleshooting information Thomas Huth
2021-05-03 10:44 ` [PULL 09/10] libqtest: refuse QTEST_QEMU_BINARY=qemu-kvm Thomas Huth
2021-05-03 10:44 ` [PULL 10/10] util/compatfd.c: Replaced a malloc call with g_malloc Thomas Huth
2021-05-05 18:06 ` [PULL 00/10] Gitlab-CI, qtest, moxie removal and misc patches Peter Maydell
2021-05-06 7:00 ` Thomas Huth
2021-05-06 7:38 ` Peter Maydell
2021-05-07 9:45 ` Thomas Huth
2021-05-07 12:41 ` Paolo Bonzini
2021-05-09 16:05 ` Thomas Huth
2021-05-14 10:22 ` Philippe Mathieu-Daudé
2021-05-14 10:25 ` Thomas Huth
2021-05-20 2:40 ` Philippe Mathieu-Daudé
2021-05-20 5:08 ` Thomas Huth
2021-05-20 7:43 ` Paolo Bonzini
2021-05-20 13:06 ` Philippe Mathieu-Daudé
2021-05-20 13:10 ` Peter Maydell
2021-05-07 12:53 ` Eric Blake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=da0b1f8a-669c-3998-c3a3-a4660d6867b8@redhat.com \
--to=eblake@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).