From: Jeff Cody <jcody@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, pbonzini@redhat.com, eblake@redhat.com,
supriyak@linux.vnet.ibm.com
Subject: [Qemu-devel] [PATCH v4 19/19] block: remove keep_read_only flag from BlockDriverState struct
Date: Thu, 20 Sep 2012 15:13:35 -0400 [thread overview]
Message-ID: <da3eb3b30b29f3cefc258bcdbba58bb75b22408b.1348157913.git.jcody@redhat.com> (raw)
In-Reply-To: <cover.1348157913.git.jcody@redhat.com>
In-Reply-To: <cover.1348157913.git.jcody@redhat.com>
The keep_read_only flag is no longer used, in favor of the bdrv
flag BDRV_O_ALLOW_RDWR.
Signed-off-by: Jeff Cody <jcody@redhat.com>
---
block.c | 2 --
block_int.h | 1 -
2 files changed, 3 deletions(-)
diff --git a/block.c b/block.c
index 84544d2..751ebdc 100644
--- a/block.c
+++ b/block.c
@@ -812,8 +812,6 @@ int bdrv_open(BlockDriverState *bs, const char *filename, int flags,
flags |= BDRV_O_ALLOW_RDWR;
}
- bs->keep_read_only = !(flags & BDRV_O_ALLOW_RDWR);
-
/* Open the image */
ret = bdrv_open_common(bs, filename, flags, drv);
if (ret < 0) {
diff --git a/block_int.h b/block_int.h
index 22b3d93..ac4245c 100644
--- a/block_int.h
+++ b/block_int.h
@@ -275,7 +275,6 @@ struct BlockDriverState {
int64_t total_sectors; /* if we are reading a disk image, give its
size in sectors */
int read_only; /* if true, the media is read only */
- int keep_read_only; /* if true, the media was requested to stay read only */
int open_flags; /* flags used to open the file, re-used for re-open */
int encrypted; /* if true, the media is encrypted */
int valid_key; /* if true, a valid encryption key has been set */
--
1.7.11.4
next prev parent reply other threads:[~2012-09-20 19:14 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-20 19:13 [Qemu-devel] [PATCH v4 00/19] block: bdrv_reopen() patches Jeff Cody
2012-09-20 19:13 ` [Qemu-devel] [PATCH v4 01/19] block: correctly set the keep_read_only flag Jeff Cody
2012-09-20 19:13 ` [Qemu-devel] [PATCH v4 02/19] block: make bdrv_set_enable_write_cache() modify open_flags Jeff Cody
2012-09-20 19:13 ` [Qemu-devel] [PATCH v4 03/19] block: Framework for reopening files safely Jeff Cody
2012-09-20 19:13 ` [Qemu-devel] [PATCH v4 04/19] block: move aio initialization into a helper function Jeff Cody
2012-09-21 10:03 ` Kevin Wolf
2012-09-20 19:13 ` [Qemu-devel] [PATCH v4 05/19] block: move open flag parsing in raw block drivers to helper functions Jeff Cody
2012-09-20 19:13 ` [Qemu-devel] [PATCH v4 06/19] block: do not parse BDRV_O_CACHE_WB in block drivers Jeff Cody
2012-09-20 19:13 ` [Qemu-devel] [PATCH v4 07/19] block: use BDRV_O_NOCACHE instead of s->aligned_buf in raw-posix.c Jeff Cody
2012-09-20 19:13 ` [Qemu-devel] [PATCH v4 08/19] block: purge s->aligned_buf and s->aligned_buf_size from raw-posix.c Jeff Cody
2012-09-20 19:13 ` [Qemu-devel] [PATCH v4 09/19] block: raw-posix image file reopen Jeff Cody
2012-09-20 19:13 ` [Qemu-devel] [PATCH v4 10/19] block: raw " Jeff Cody
2012-09-20 19:13 ` [Qemu-devel] [PATCH v4 11/19] block: qed " Jeff Cody
2012-09-20 19:13 ` [Qemu-devel] [PATCH v4 12/19] block: qcow2 " Jeff Cody
2012-09-20 19:13 ` [Qemu-devel] [PATCH v4 13/19] block: qcow " Jeff Cody
2012-09-20 19:13 ` [Qemu-devel] [PATCH v4 14/19] block: vmdk " Jeff Cody
2012-09-20 19:13 ` [Qemu-devel] [PATCH v4 15/19] block: raw-win32 driver reopen support Jeff Cody
2012-09-21 8:33 ` Kevin Wolf
2012-09-21 8:43 ` Paolo Bonzini
2012-09-21 12:17 ` Jeff Cody
2012-09-21 12:31 ` Paolo Bonzini
2012-09-20 19:13 ` [Qemu-devel] [PATCH v4 16/19] block: vdi image file reopen Jeff Cody
2012-09-20 19:13 ` [Qemu-devel] [PATCH v4 17/19] block: vpc " Jeff Cody
2012-09-20 19:13 ` [Qemu-devel] [PATCH v4 18/19] block: convert bdrv_commit() to use bdrv_reopen() Jeff Cody
2012-09-20 19:13 ` Jeff Cody [this message]
2012-09-21 10:39 ` [Qemu-devel] [PATCH v4 00/19] block: bdrv_reopen() patches Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=da3eb3b30b29f3cefc258bcdbba58bb75b22408b.1348157913.git.jcody@redhat.com \
--to=jcody@redhat.com \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=supriyak@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).