* [PATCH v2] hw/arm/smmuv3: Fix addr_mask for range-based invalidation
@ 2021-01-30 4:32 Zenghui Yu
2021-01-31 16:12 ` Auger Eric
2021-02-02 11:30 ` Peter Maydell
0 siblings, 2 replies; 3+ messages in thread
From: Zenghui Yu @ 2021-01-30 4:32 UTC (permalink / raw)
To: qemu-devel, qemu-arm, eric.auger, peter.maydell
Cc: Zenghui Yu, wanghaibin.wang
When handling guest range-based IOTLB invalidation, we should decode the TG
field into the corresponding translation granule size so that we can pass
the correct invalidation range to backend. Set @granule to (tg * 2 + 10) to
properly emulate the architecture.
Fixes: d52915616c05 ("hw/arm/smmuv3: Get prepared for range invalidation")
Signed-off-by: Zenghui Yu <yuzenghui@huawei.com>
---
* From v1:
- Fix the compilation error
hw/arm/smmuv3.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/hw/arm/smmuv3.c b/hw/arm/smmuv3.c
index bbca0e9f20..98b99d4fe8 100644
--- a/hw/arm/smmuv3.c
+++ b/hw/arm/smmuv3.c
@@ -801,7 +801,7 @@ static void smmuv3_notify_iova(IOMMUMemoryRegion *mr,
{
SMMUDevice *sdev = container_of(mr, SMMUDevice, iommu);
IOMMUTLBEvent event;
- uint8_t granule = tg;
+ uint8_t granule;
if (!tg) {
SMMUEventInfo event = {.inval_ste_allowed = true};
@@ -821,6 +821,8 @@ static void smmuv3_notify_iova(IOMMUMemoryRegion *mr,
return;
}
granule = tt->granule_sz;
+ } else {
+ granule = tg * 2 + 10;
}
event.type = IOMMU_NOTIFIER_UNMAP;
--
2.19.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v2] hw/arm/smmuv3: Fix addr_mask for range-based invalidation
2021-01-30 4:32 [PATCH v2] hw/arm/smmuv3: Fix addr_mask for range-based invalidation Zenghui Yu
@ 2021-01-31 16:12 ` Auger Eric
2021-02-02 11:30 ` Peter Maydell
1 sibling, 0 replies; 3+ messages in thread
From: Auger Eric @ 2021-01-31 16:12 UTC (permalink / raw)
To: Zenghui Yu, qemu-devel, qemu-arm, peter.maydell; +Cc: wanghaibin.wang
Hi Zenghui,
On 1/30/21 5:32 AM, Zenghui Yu wrote:
> When handling guest range-based IOTLB invalidation, we should decode the TG
> field into the corresponding translation granule size so that we can pass
> the correct invalidation range to backend. Set @granule to (tg * 2 + 10) to
> properly emulate the architecture.
>
> Fixes: d52915616c05 ("hw/arm/smmuv3: Get prepared for range invalidation")
> Signed-off-by: Zenghui Yu <yuzenghui@huawei.com>
> ---
> * From v1:
> - Fix the compilation error
>
> hw/arm/smmuv3.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/hw/arm/smmuv3.c b/hw/arm/smmuv3.c
> index bbca0e9f20..98b99d4fe8 100644
> --- a/hw/arm/smmuv3.c
> +++ b/hw/arm/smmuv3.c
> @@ -801,7 +801,7 @@ static void smmuv3_notify_iova(IOMMUMemoryRegion *mr,
> {
> SMMUDevice *sdev = container_of(mr, SMMUDevice, iommu);
> IOMMUTLBEvent event;
> - uint8_t granule = tg;
> + uint8_t granule;
>
> if (!tg) {
> SMMUEventInfo event = {.inval_ste_allowed = true};
> @@ -821,6 +821,8 @@ static void smmuv3_notify_iova(IOMMUMemoryRegion *mr,
> return;
> }
> granule = tt->granule_sz;
> + } else {
> + granule = tg * 2 + 10;
> }
>
> event.type = IOMMU_NOTIFIER_UNMAP;
>
Acked-by: Eric Auger <eric.auger@redhat.com>
Thanks
Eric
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2] hw/arm/smmuv3: Fix addr_mask for range-based invalidation
2021-01-30 4:32 [PATCH v2] hw/arm/smmuv3: Fix addr_mask for range-based invalidation Zenghui Yu
2021-01-31 16:12 ` Auger Eric
@ 2021-02-02 11:30 ` Peter Maydell
1 sibling, 0 replies; 3+ messages in thread
From: Peter Maydell @ 2021-02-02 11:30 UTC (permalink / raw)
To: Zenghui Yu; +Cc: Eric Auger, qemu-arm, QEMU Developers, wanghaibin.wang
On Sat, 30 Jan 2021 at 04:32, Zenghui Yu <yuzenghui@huawei.com> wrote:
>
> When handling guest range-based IOTLB invalidation, we should decode the TG
> field into the corresponding translation granule size so that we can pass
> the correct invalidation range to backend. Set @granule to (tg * 2 + 10) to
> properly emulate the architecture.
>
> Fixes: d52915616c05 ("hw/arm/smmuv3: Get prepared for range invalidation")
> Signed-off-by: Zenghui Yu <yuzenghui@huawei.com>
> ---
> * From v1:
> - Fix the compilation error
>
> hw/arm/smmuv3.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/hw/arm/smmuv3.c b/hw/arm/smmuv3.c
> index bbca0e9f20..98b99d4fe8 100644
> --- a/hw/arm/smmuv3.c
> +++ b/hw/arm/smmuv3.c
> @@ -801,7 +801,7 @@ static void smmuv3_notify_iova(IOMMUMemoryRegion *mr,
> {
> SMMUDevice *sdev = container_of(mr, SMMUDevice, iommu);
> IOMMUTLBEvent event;
> - uint8_t granule = tg;
> + uint8_t granule;
>
> if (!tg) {
> SMMUEventInfo event = {.inval_ste_allowed = true};
> @@ -821,6 +821,8 @@ static void smmuv3_notify_iova(IOMMUMemoryRegion *mr,
> return;
> }
> granule = tt->granule_sz;
> + } else {
> + granule = tg * 2 + 10;
> }
>
> event.type = IOMMU_NOTIFIER_UNMAP;
Applied to target-arm.next, thanks.
-- PMM
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-02-02 11:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-01-30 4:32 [PATCH v2] hw/arm/smmuv3: Fix addr_mask for range-based invalidation Zenghui Yu
2021-01-31 16:12 ` Auger Eric
2021-02-02 11:30 ` Peter Maydell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).