From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Cy8xp-0001JL-B1
	for qemu-devel@nongnu.org; Mon, 07 Feb 2005 08:30:06 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Cy8xl-0001Ik-40
	for qemu-devel@nongnu.org; Mon, 07 Feb 2005 08:30:02 -0500
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Cy8xU-0000rW-Bv
	for qemu-devel@nongnu.org; Mon, 07 Feb 2005 08:29:44 -0500
Received: from [64.233.184.202] (helo=wproxy.gmail.com)
	by monty-python.gnu.org with esmtp (Exim 4.34) id 1Cy8Y2-0001cF-Ew
	for qemu-devel@nongnu.org; Mon, 07 Feb 2005 08:03:26 -0500
Received: by wproxy.gmail.com with SMTP id 70so1723260wra
	for <qemu-devel@nongnu.org>; Mon, 07 Feb 2005 05:03:23 -0800 (PST)
Message-ID: <da63183705020705033ae623f1@mail.gmail.com>
Date: Mon, 7 Feb 2005 13:03:22 +0000
From: Piotras <piotras@gmail.com>
Subject: Re: [Qemu-devel] testandset asm fix
In-Reply-To: <200502061443.38384.paul@codesourcery.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
References: <200502061443.38384.paul@codesourcery.com>
Reply-To: Piotras <piotras@gmail.com>, qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

m68k has similar problem

http://lists.gnu.org/archive/html/qemu-devel/2004-08/msg00122.html


Regards,

Piotrek

On Sun, 6 Feb 2005 14:43:38 +0000, Paul Brook <paul@codesourcery.com> wrote:
> The inline assembly used for the x86/x86-64 host testandset routine is bogus.
> The operand constraints are wrong (Fails to compile at -O0).
> Also the return value is incorrect. It should return 0 if the lock was
> successfully acquired.
> 
> Patch below fixes it. The additional sete test is unnecessary, we can just use
> the comparison/writeback value.
> 
> Paul
> 
> Index: exec-all.h
> ===================================================================
> RCS file: /cvsroot/qemu/qemu/exec-all.h,v
> retrieving revision 1.26
> diff -u -p -r1.26 exec-all.h
> --- exec-all.h 10 Jan 2005 23:23:48 -0000 1.26
> +++ exec-all.h 6 Feb 2005 14:35:43 -0000
> @@ -392,28 +392,24 @@ static inline int testandset (int *p)
> #ifdef __i386__
> static inline int testandset (int *p)
> {
> -    char ret;
> -    long int readval;
> -
> -    __asm__ __volatile__ ("lock; cmpxchgl %3, %1; sete %0"
> -                          : "=q" (ret), "=m" (*p), "=a" (readval)
> -                          : "r" (1), "m" (*p), "a" (0)
> -                          : "memory");
> -    return ret;
> +    long int readval = 0;
> +
> +    __asm__ __volatile__ ("lock; cmpxchgl %2, %0"
> +                          : "+m" (*p), "+a" (readval)
> +                          : "r" (1));
> +    return readval;
> }
> #endif
> 
> #ifdef __x86_64__
> static inline int testandset (int *p)
> {
> -    char ret;
> -    int readval;
> -
> -    __asm__ __volatile__ ("lock; cmpxchgl %3, %1; sete %0"
> -                          : "=q" (ret), "=m" (*p), "=a" (readval)
> -                          : "r" (1), "m" (*p), "a" (0)
> -                          : "memory");
> -    return ret;
> +    long int readval = 0;
> +
> +    __asm__ __volatile__ ("lock; cmpxchgl %2, %0"
> +                          : "+m" (*p), "+a" (readval)
> +                          : "r" (1));
> +    return readval;
> }
> #endif
> 
> _______________________________________________
> Qemu-devel mailing list
> Qemu-devel@nongnu.org
> http://lists.nongnu.org/mailman/listinfo/qemu-devel
>