qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Frederic Barrat <fbarrat@linux.ibm.com>
To: "Joel Stanley" <joel@jms.id.au>,
	"Cédric Le Goater" <clg@kaod.org>,
	"Nicholas Piggin" <npiggin@gmail.com>
Cc: qemu-devel@nongnu.org, qemu-ppc@nongnu.org
Subject: Re: [PATCH 3/4] ppc/pnv: Add P10 quad ops
Date: Fri, 30 Jun 2023 09:30:41 +0200	[thread overview]
Message-ID: <da80494b-0626-62f5-65b7-1e4b0901ee27@linux.ibm.com> (raw)
In-Reply-To: <20230630035547.80329-4-joel@jms.id.au>



On 30/06/2023 05:55, Joel Stanley wrote:
> diff --git a/hw/ppc/pnv_core.c b/hw/ppc/pnv_core.c
> index b9a57463aec4..7fff2fd9e298 100644
> --- a/hw/ppc/pnv_core.c
> +++ b/hw/ppc/pnv_core.c

> +static uint64_t pnv_quad_power10_xscom_read(void *opaque, hwaddr addr,
...
> +        qemu_log_mask(LOG_UNIMP, "%s: writing @0x%08x\n", __func__,

                                          ^^^ reading

I'm guessing we'll need to flush out that function pretty soon, so not 
worth resending.

   Fred


  parent reply	other threads:[~2023-06-30  7:31 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-30  3:55 [PATCH 0/4] ppc/pnv: Extend "quad" model for p10 Joel Stanley
2023-06-30  3:55 ` [PATCH 1/4] ppc/pnv: quad xscom callbacks are P9 specific Joel Stanley
2023-06-30  5:23   ` Cédric Le Goater
2023-06-30  3:55 ` [PATCH 2/4] ppc/pnv: Subclass quad xscom callbacks Joel Stanley
2023-06-30  5:24   ` Cédric Le Goater
2023-06-30  3:55 ` [PATCH 3/4] ppc/pnv: Add P10 quad ops Joel Stanley
2023-06-30  5:24   ` Cédric Le Goater
2023-06-30  7:30   ` Frederic Barrat [this message]
2023-06-30  7:35     ` Joel Stanley
2023-06-30  7:44       ` Cédric Le Goater
2023-06-30 13:47         ` Daniel Henrique Barboza
2023-06-30  3:55 ` [PATCH 4/4] ppc/pnv: Return zero for core thread state xscom Joel Stanley
2023-06-30  5:24   ` Cédric Le Goater
2023-07-01 10:22   ` Nicholas Piggin
2023-07-01 10:10 ` [PATCH 0/4] ppc/pnv: Extend "quad" model for p10 Nicholas Piggin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=da80494b-0626-62f5-65b7-1e4b0901ee27@linux.ibm.com \
    --to=fbarrat@linux.ibm.com \
    --cc=clg@kaod.org \
    --cc=joel@jms.id.au \
    --cc=npiggin@gmail.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).