From: Laurent Vivier <laurent@vivier.eu>
To: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>, qemu-devel@nongnu.org
Subject: Re: [PATCH v4 09/20] macfb: don't register declaration ROM
Date: Mon, 20 Sep 2021 23:44:52 +0200 [thread overview]
Message-ID: <da82daeb-7226-46ff-5c0e-4025b24ba3d0@vivier.eu> (raw)
In-Reply-To: <a65fbc89-681c-22b5-87d4-31d37de15559@vivier.eu>
Le 20/09/2021 à 22:01, Laurent Vivier a écrit :
> Le 17/09/2021 à 09:50, Mark Cave-Ayland a écrit :
>> The macfb device is an on-board framebuffer and so is initialised by the
>> system declaration ROM included within the MacOS toolbox ROM.
>>
>> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
>> ---
>> hw/display/macfb.c | 6 ------
>> 1 file changed, 6 deletions(-)
>>
>> diff --git a/hw/display/macfb.c b/hw/display/macfb.c
>> index d8183b9bbd..76808b69cc 100644
>> --- a/hw/display/macfb.c
>> +++ b/hw/display/macfb.c
>> @@ -383,10 +383,6 @@ static void macfb_sysbus_realize(DeviceState *dev, Error **errp)
>> sysbus_init_mmio(SYS_BUS_DEVICE(s), &ms->mem_vram);
>> }
>>
>> -const uint8_t macfb_rom[] = {
>> - 255, 0, 0, 0,
>> -};
>> -
>> static void macfb_nubus_realize(DeviceState *dev, Error **errp)
>> {
>> NubusDevice *nd = NUBUS_DEVICE(dev);
>> @@ -399,8 +395,6 @@ static void macfb_nubus_realize(DeviceState *dev, Error **errp)
>> macfb_common_realize(dev, ms, errp);
>> memory_region_add_subregion(&nd->slot_mem, DAFB_BASE, &ms->mem_ctrl);
>> memory_region_add_subregion(&nd->slot_mem, VIDEO_BASE, &ms->mem_vram);
>> -
>> - nubus_register_rom(nd, macfb_rom, sizeof(macfb_rom), 1, 9, 0xf);
>> }
>>
>> static void macfb_sysbus_reset(DeviceState *d)
>>
>
> Will macfb continue to work with "-kernel" and without providing any MacOS ROM?
My Quadra doesn't seem to report any ROM on boot, so it must be fine
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
next prev parent reply other threads:[~2021-09-20 22:07 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-17 7:50 [PATCH v4 00/20] nubus: bus, device, bridge, IRQ and address space improvements Mark Cave-Ayland
2021-09-17 7:50 ` [PATCH v4 01/20] nubus-device: rename slot_nb variable to slot Mark Cave-Ayland
2021-09-20 17:23 ` Laurent Vivier
2021-09-17 7:50 ` [PATCH v4 02/20] nubus-device: expose separate super slot memory region Mark Cave-Ayland
2021-09-20 19:54 ` Laurent Vivier
2021-09-22 10:24 ` Mark Cave-Ayland
2021-09-17 7:50 ` [PATCH v4 03/20] nubus-device: add device slot parameter Mark Cave-Ayland
2021-09-20 17:31 ` Laurent Vivier
2021-09-21 17:14 ` Mark Cave-Ayland
2021-09-17 7:50 ` [PATCH v4 04/20] nubus: use bitmap to manage available slots Mark Cave-Ayland
2021-09-20 19:48 ` Laurent Vivier
2021-09-21 17:24 ` Mark Cave-Ayland
2021-09-17 7:50 ` [PATCH v4 05/20] nubus: move slot bitmap checks from NubusDevice realize() to BusClass check_address() Mark Cave-Ayland
2021-09-20 19:56 ` Laurent Vivier
2021-09-22 10:26 ` Mark Cave-Ayland
2021-09-17 7:50 ` [PATCH v4 06/20] nubus: implement BusClass get_dev_path() Mark Cave-Ayland
2021-09-20 19:57 ` Laurent Vivier
2021-09-17 7:50 ` [PATCH v4 07/20] nubus: add trace-events for empty slot accesses Mark Cave-Ayland
2021-09-20 19:58 ` Laurent Vivier
2021-09-17 7:50 ` [PATCH v4 08/20] nubus: generate bus error when attempting to access empty slots Mark Cave-Ayland
2021-09-20 19:59 ` Laurent Vivier
2021-09-17 7:50 ` [PATCH v4 09/20] macfb: don't register declaration ROM Mark Cave-Ayland
2021-09-20 20:01 ` Laurent Vivier
2021-09-20 21:44 ` Laurent Vivier [this message]
2021-09-22 10:28 ` Mark Cave-Ayland
2021-09-22 11:15 ` BALATON Zoltan
2021-09-22 11:31 ` Mark Cave-Ayland
2021-09-17 7:50 ` [PATCH v4 10/20] nubus-device: remove nubus_register_rom() and nubus_register_format_block() Mark Cave-Ayland
2021-09-20 21:45 ` Laurent Vivier
2021-09-17 7:50 ` [PATCH v4 11/20] nubus-device: add romfile property for loading declaration ROMs Mark Cave-Ayland
2021-09-20 21:47 ` Laurent Vivier
2021-09-17 7:50 ` [PATCH v4 12/20] nubus: move nubus to its own 32-bit address space Mark Cave-Ayland
2021-09-17 7:50 ` [PATCH v4 13/20] nubus-bridge: introduce separate NubusBridge structure Mark Cave-Ayland
2021-09-17 7:50 ` [PATCH v4 14/20] mac-nubus-bridge: rename MacNubusState to MacNubusBridge Mark Cave-Ayland
2021-09-17 7:50 ` [PATCH v4 15/20] nubus: move NubusBus from mac-nubus-bridge to nubus-bridge Mark Cave-Ayland
2021-09-17 7:50 ` [PATCH v4 16/20] nubus-bridge: embed the NubusBus object directly within nubus-bridge Mark Cave-Ayland
2021-09-17 7:50 ` [PATCH v4 17/20] nubus-bridge: make slot_available_mask a qdev property Mark Cave-Ayland
2021-09-20 20:12 ` Laurent Vivier
2021-09-22 11:50 ` Mark Cave-Ayland
2021-09-17 7:50 ` [PATCH v4 18/20] nubus: add support for slot IRQs Mark Cave-Ayland
2021-09-20 21:40 ` Laurent Vivier
2021-09-17 7:50 ` [PATCH v4 19/20] q800: wire up nubus IRQs Mark Cave-Ayland
2021-09-20 21:43 ` Laurent Vivier
2021-09-17 7:50 ` [PATCH v4 20/20] q800: configure nubus available slots for Quadra 800 Mark Cave-Ayland
2021-09-20 21:40 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=da82daeb-7226-46ff-5c0e-4025b24ba3d0@vivier.eu \
--to=laurent@vivier.eu \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).