Re: [Qemu-devel] [PATCH v2 3/6] nbd/server: add errp to nbd_send_reply()

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 961 bytes --]

On 06/21/2017 10:34 AM, Vladimir Sementsov-Ogievskiy wrote:
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---
>  nbd/server.c | 17 +++++++++--------
>  1 file changed, 9 insertions(+), 8 deletions(-)
> 

> @@ -1266,8 +1267,8 @@ reply:
>          local_err = NULL;
>      }
>  
> -    if (nbd_co_send_reply(req, &reply, reply_data_len) < 0) {
> -        error_setg(&local_err, "Failed to send reply");
> +    if (nbd_co_send_reply(req, &reply, reply_data_len, &local_err) < 0) {
> +        error_prepend(&local_err, "Failed to send reply: ");
>          goto disconnect;

Again, I'm not sure if the error_prepend is necessary vs. just directly
reusing the error from earlier in the stack.  But it's not enough to
stop me from giving:

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]