Re: [PATCH v2 03/38] hw/s390x/vfio: Replace TARGET_PAGE_BITS -> qemu_target_page_bits()

["Cédric Le Goater" <clegoate@redhat.com>]

On 3/13/26 11:25, Thomas Huth wrote:
> On 13/03/2026 07.20, Philippe Mathieu-Daudé wrote:
>> Get the target page bits at runtime.
>>
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>> ---
>>   hw/s390x/s390-pci-vfio.c | 3 ++-
>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/hw/s390x/s390-pci-vfio.c b/hw/s390x/s390-pci-vfio.c
>> index 8ce44dbecce..7c754b656da 100644
>> --- a/hw/s390x/s390-pci-vfio.c
>> +++ b/hw/s390x/s390-pci-vfio.c
>> @@ -22,6 +22,7 @@
>>   #include "hw/vfio/pci.h"
>>   #include "hw/vfio/vfio-container-legacy.h"
>>   #include "hw/vfio/vfio-helpers.h"
>> +#include "exec/target_page.h"
>>   /*
>>    * Get the current DMA available count from vfio.  Returns true if vfio is
>> @@ -150,7 +151,7 @@ static void s390_pci_read_base(S390PCIBusDevice *pbdev,
>>        * to request that the guest free DMA mappings as necessary.
>>        */
>>       if (!pbdev->rtr_avail) {
>> -        vfio_size = pbdev->iommu->max_dma_limit << TARGET_PAGE_BITS;
>> +        vfio_size = pbdev->iommu->max_dma_limit << qemu_target_page_bits();
>>           if (vfio_size > 0 && vfio_size < cap->end_dma - cap->start_dma + 1) {
>>               pbdev->zpci_fn.edma = cap->start_dma + vfio_size - 1;
>>           }
> 
> Reviewed-by: Thomas Huth <thuth@redhat.com>
> 

Reviewed-by: Cédric Le Goater <clg@redhat.com>

Thanks,

C.