Re: [PATCH 2/5] target/sparc/cpu: Avoid spaces by default in the CPU names

[Richard Henderson <richard.henderson@linaro.org>]

On 3/7/24 07:43, Thomas Huth wrote:
> The output of "-cpu help" is currently rather confusing to the users:
> It is not clear which part of the output defines the CPU names since
> the CPU names contain white spaces (which we later have to convert
> into dashes internally) For example:
> 
> Sparc TI UltraSparc II IU 0017001120000000 FPU 00000000 MMU 00000000 NWINS 8
> 
> At a first glance, should the name for -cpu be "Sparc TI Ultrasparc II"
> or "TI UltraSparc II IU" here? Both would be wrong, the right guess is
> "TI UltraSparc II" only. Let's start cleaning up this mess by using
> dashes instead of white spaces for the CPU names, like we're doing it
> internally later (and like we're doing it in most other targets of QEMU).
> Note that it is still possible to pass the CPU names with spaces to the
> "-cpu" option, since sparc_cpu_type_name() still translates those to "-".
> 
> Buglink:https://gitlab.com/qemu-project/qemu/-/issues/2141
> Signed-off-by: Thomas Huth<thuth@redhat.com>
> ---
>   target/sparc/cpu.c | 56 +++++++++++++++++++++++-----------------------
>   1 file changed, 28 insertions(+), 28 deletions(-)

I think the names are still a bit too long, and the case sensitivity is a titch annoying. 
But it's still an improvement, and I don't want to bike-shed this too much.

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~