qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, Stefan Weil <sw@weilnetz.de>,
	Yonggang Luo <luoyonggang@gmail.com>,
	Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH] configure: Symlink binaries using .exe suffix with MinGW
Date: Wed, 15 Dec 2021 11:52:39 +0100	[thread overview]
Message-ID: <dac2e8e7-87f2-7998-13a0-2529b7226e48@redhat.com> (raw)
In-Reply-To: <20211109144504.1541206-1-philmd@redhat.com>

Hi Laurent,

This patch is reviewed/acked, can it go via your trivial tree?

On 11/9/21 15:45, Philippe Mathieu-Daudé wrote:
> When using the MinGW toolchain, we use the .exe suffix for the
> executable name. We also need to use it for the symlinks in the
> build directory.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  configure | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configure b/configure
> index 48c21775f3a..31e8f586dc7 100755
> --- a/configure
> +++ b/configure
> @@ -3786,7 +3786,7 @@ fi
>  
>  for target in $target_list; do
>      target_dir="$target"
> -    target_name=$(echo $target | cut -d '-' -f 1)
> +    target_name=$(echo $target | cut -d '-' -f 1)$EXESUF
>      mkdir -p $target_dir
>      case $target in
>          *-user) symlink "../qemu-$target_name" "$target_dir/qemu-$target_name" ;;
> 



  parent reply	other threads:[~2021-12-15 11:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-09 14:45 [PATCH] configure: Symlink binaries using .exe suffix with MinGW Philippe Mathieu-Daudé
2021-11-09 17:23 ` Stefan Weil
2021-11-09 17:59 ` Paolo Bonzini
2021-12-15 10:52 ` Philippe Mathieu-Daudé [this message]
2021-12-17  9:40 ` Laurent Vivier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dac2e8e7-87f2-7998-13a0-2529b7226e48@redhat.com \
    --to=philmd@redhat.com \
    --cc=luoyonggang@gmail.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=sw@weilnetz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).